Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@VanessaSingh
Copy link

Description

This PR aims to fix issue #19003. Updating the parameter documentation for functions to make it consistent with their signatures.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

Updating parameter documentation for functions check_numeric_gradient(), check_symbolic_forward(), check_symbolic_backward().

@VanessaSingh VanessaSingh requested a review from szha as a code owner September 1, 2020 02:40
@mxnet-bot
Copy link

Hey @VanessaSingh , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-gpu, website, unix-cpu, clang, windows-gpu, sanity, edge, unix-gpu, windows-cpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha
Copy link
Member

szha commented Sep 1, 2020

@VanessaSingh thanks for the contribution! At the moment there's an issue with setuptools which caused the CI to clog. #19061 should unblock it soon.

@ChaiBapchya
Copy link
Contributor

#19061 this one is merged. @VanessaSingh can you please rebase? Thanks

@leezu leezu merged commit 5051fd9 into apache:v1.x Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants