This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Remove duplicate setup and teardown functions #19254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [sanity, centos-cpu, edge, website, miscellaneous, windows-cpu, centos-gpu, windows-gpu, clang, unix-gpu, unix-cpu] Note: |
leezu
force-pushed
the
2020-09/fix-pytest-setup-teardown
branch
from
ee72402 to
641f12b
Compare
faccd91 introduced a automatic pytest hooks for handling MXNET_MODULE_SEED adapted from dmlc/gluon-nlp@66e926a but didn't remove the existing seed handling via explicit setup and teardown functions. This commit removes the explicit setup and teardown functions in favor of the automatic pytest version, and thereby also ensures that the seed handling code is not executed twice. As a side benefit, seed handling now works correctly even if contributors forget to add the magic setup_module and teardown_module imports in new test files. If pytest is run with --capture=no (or -s shorthand), output of the module level fixtures is shown to the user.
leezu
force-pushed
the
2020-09/fix-pytest-setup-teardown
branch
2 times, most recently
from
b5c96be to
987e227
Compare
leezu
force-pushed
the
2020-09/fix-pytest-setup-teardown
branch
from
987e227 to
e2b65fb
Compare
Contributor
Author
|
@mxnet-bot run ci [miscellaneous] |
|
Jenkins CI successfully triggered : [miscellaneous] |
Contributor
Author
|
@mxnet-bot run ci [miscellaneous] |
|
Jenkins CI successfully triggered : [miscellaneous] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faccd91 introduced a automatic pytest hooks for handling MXNET_MODULE_SEED adapted from https://github.com/dmlc/gluon-nlp/blob/917855b/conftest.py but didn't yet remove the existing seed handling via explicit setup and teardown functions.
This commit removes the explicit setup and teardown functions in favor of the
automatic pytest version, and thereby also ensures that the seed handling code
is not executed twice. As a side benefit, seed handling now works correctly even
if contributors forget to add the magic setup_module and teardown_module
imports in new test files.
If pytest is run with --capture=no (or -s shorthand), output of the module level
fixtures is shown to the user.