-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Fix AtWithRecord #19374
Fix AtWithRecord #19374
Conversation
Prior implementation recorded reshape with concrete shapes used during the particular invocation of At. New implementation uses records reshape with magic numbers to match symbolic interface.
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [clang, miscellaneous, centos-cpu, windows-gpu, edge, sanity, unix-gpu, website, unix-cpu, centos-gpu, windows-cpu] Note: |
sxjscience
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mxnet-bot run ci [centos-cpu, centos-gpu, edge, miscellaneous, unix-gpu] |
|
Jenkins CI successfully triggered : [edge, unix-gpu, centos-gpu, centos-cpu, miscellaneous] |
|
@mxnet-bot run ci [centos-gpu, edge, miscellaneous, unix-gpu, unix-cpu] |
|
Jenkins CI successfully triggered : [miscellaneous, edge, centos-gpu, unix-gpu, unix-cpu] |
|
@mxnet-bot run ci [miscellaneous, unix-gpu, unix-cpu] |
|
Jenkins CI successfully triggered : [miscellaneous, unix-cpu, unix-gpu] |
|
@mxnet-bot run ci [miscellaneous, unix-gpu] |
|
Jenkins CI successfully triggered : [miscellaneous, unix-gpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
Prior implementation recorded reshape with concrete shapes used during the particular invocation of At.
New implementation uses records reshape with magic numbers to match symbolic interface.
Example of failure without this patch
Details on failure
Json export of the recorded graph contains the following segment. We can see the shape of the first forward pass was hardcoded by the
AtWithRecordimplementation.