This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] Fix windows dll loading for compute capabilties >7.5 #19410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously any higher compute capabilties would load mxnet_75.dll Any new compute capabilities should now load the correct dll if present
|
Hey @vladoovtcharov , Thanks for submitting the PR
CI supported jobs: [unix-gpu, edge, windows-gpu, windows-cpu, centos-cpu, clang, miscellaneous, unix-cpu, sanity, website, centos-gpu] Note: |
lanking520
added
pr-awaiting-testing
Contributor
Author
|
@mxnet-bot run ci [Greetings, windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu] |
lanking520
added
pr-awaiting-testing
yajiedesign
approved these changes
Oct 26, 2020
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Nov 17, 2020
Previously any higher compute capabilties would load mxnet_75.dll Any new compute capabilities should now load the correct dll if present Co-authored-by: vlado <vlado@indicalab.com>
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Nov 19, 2020
Previously any higher compute capabilties would load mxnet_75.dll Any new compute capabilities should now load the correct dll if present Co-authored-by: vlado <vlado@indicalab.com>
This was referenced Nov 25, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Feb 19, 2021
Previously any higher compute capabilties would load mxnet_75.dll Any new compute capabilities should now load the correct dll if present Co-authored-by: vlado <vlado@indicalab.com>
leezu
pushed a commit
that referenced
this pull request
Feb 22, 2021
Backport #19410 Previously any higher compute capabilties would load mxnet_75.dll Any new compute capabilities should now load the correct dll if present Co-authored-by: vlado <vladoovtcharov@gmail.com> Co-authored-by: vlado <vlado@indicalab.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any higher compute capabilities would load mxnet_75.dll
Any new compute capabilities should now load the correct dll if present
Description
Newer gpus were incorrectly trying to load mxnet_75.dll instead of mxnet_80.dll or mxnet_86.dll
Changes
Fixed searching logic to look for any newer compute capabilities as well