This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix HLS2RGBConvert #19516
Merged
Fix HLS2RGBConvert #19516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For small h (eg. -2.22524022E-7), h += 6 will yield a h == 6. But c_HlsSectorData[6] is invalid memory leading to segmentation fault. We need to decrement to 0. Can be reproduced (prior to this commit via): MXNET_TEST_SEED=1492532915 python3.8 -m pytest tests/python/unittest/test_numpy_contrib_gluon_data_vision.py::TestImage::test_bbox_augmenters
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [clang, windows-cpu, windows-gpu, website, centos-gpu, miscellaneous, unix-gpu, centos-cpu, unix-cpu, sanity, edge] Note: |
lanking520
added
pr-awaiting-testing
zhreshold
approved these changes
Nov 11, 2020
Member
zhreshold
left a comment
zhreshold
left a comment
There was a problem hiding this comment.
lgtm, thanks for catching and patching!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For small h (eg. -2.22524022E-7), h += 6 will yield a h == 6. But
c_HlsSectorData[6] is invalid memory leading to segmentation fault. We need to
decrement to 0.
Can be reproduced (prior to this commit via):
MXNET_TEST_SEED=1492532915 python3.8 -m pytest tests/python/unittest/test_numpy_contrib_gluon_data_vision.py::TestImage::test_bbox_augmenters
Fixes #18986