This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] ONNX support for broadcast_mod #19770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [centos-gpu, clang, centos-cpu, edge, website, sanity, unix-cpu, unix-gpu, miscellaneous, windows-cpu, windows-gpu] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
waytrue17
reviewed
Jan 21, 2021
|
|
||
|
|
||
| @pytest.mark.parametrize('dtype', ['float16', 'float32', 'int32', 'int64']) | ||
| @pytest.mark.parametrize('shapes', [((3, 3, 3), (3)), ((4, 5, 6, 7), (7))]) |
Contributor
There was a problem hiding this comment.
Shall we also test rhs with higher dimension like (3, 3)?
…t into onnx_broadcast_mod
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MXNet broadcast mod's behavior is a mixture of np mod and fmod. So I made some adjustment in the onnx translation to make sure the behavior is the same as that of mxnet