Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix cd by adding to $PATH #19939

Merged
Zha0q1 merged 6 commits into from
Feb 24, 2021
+2 −1
Merged

Fix cd by adding to $PATH #19939

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c77a8e
change cd mxnetlib task to use g4 node
Zha0q1 Feb 20, 2021
1692b56
add g4 mapping
Zha0q1 Feb 20, 2021
0de15d0
revert changes
Zha0q1 Feb 22, 2021
1d4c90b
Update runtime_functions.sh
Zha0q1 Feb 23, 2021
d9769f8
Merge branch 'master' of github.com:apache/incubator-mxnet into maste…
Zha0q1 Feb 23, 2021
1b8462d
Update runtime_functions.sh
Zha0q1 Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/docker/runtime_functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,13 +1307,14 @@ cd_pypi_publish() {

cd_s3_publish() {
set -ex
pip3 install --user awscli
pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
export PATH=/usr/local/bin:$PATH
Copy link
Contributor

@leezu leezu Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that /usr/local/bin wasn't on the PATH before? Do you know why it worked at all before?

Copy link
Contributor Author

@Zha0q1 Zha0q1 Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently changed the ami used by restricted-mxnetlinux-gpu to update the nvidia driver

Copy link
Contributor Author

@Zha0q1 Zha0q1 Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think if there is a better place to set PATH?

Copy link
Contributor Author

@Zha0q1 Zha0q1 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leezu

Copy link
Contributor

@leezu leezu Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to add it here, I'm just trying to understand the reasoning. Can you explain how it's related to AMI? Wouldn't cd_s3_publish run in a docker container and be independent from the AMI?

aws s3 cp ${filepath} s3://apache-mxnet/dist/python/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
}

Expand Down