Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Backport TRT fixes to 1.8 #19983

Merged
ptrendx merged 3 commits into from
Mar 5, 2021
Merged

Backport TRT fixes to 1.8 #19983

ptrendx merged 3 commits into from
Mar 5, 2021

Conversation

@Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Mar 5, 2021

Backported PRs

Kh4L added 3 commits March 5, 2021 14:17
@Kh4L
Update MXNet-TRT doc with the new optimize_for API
3a2ac31 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
[1.x] Move block.optimize_for backend_opts to kwargs (apache#19386)
e5278bf 
* Move block.optimize_for backend_opts to kwargs

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Update Hybridize to use kwargs as backend opts

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Fix lint

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Change clear default to False and allow hybrize+optimize_for calls

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Fix nit

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Adress review comments

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Adress more review comments

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Adress more more review comments

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Fix nit

Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Add 1:many conversions in nnvm_to_onnx and non-flatten GEMM (apache#1…
2a4759c 
…9652)

Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L Kh4L requested review from aaronmarkham and szha as code owners March 5, 2021 05:26
@mxnet-bot
Copy link

mxnet-bot commented Mar 5, 2021

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, centos-gpu, unix-cpu, windows-gpu, windows-cpu, miscellaneous, unix-gpu, website, clang, sanity, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 5, 2021
@Kh4L Kh4L changed the title Backport TRT changes to 1.8 Backport TRT fixes to 1.8 Mar 5, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2021
@Kh4L
Copy link
Contributor Author

Kh4L commented Mar 5, 2021

@mxnet-bot run ci [unix-gpu, centos-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Mar 5, 2021

Jenkins CI successfully triggered : [unix-gpu, centos-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2021
samskalicky
samskalicky approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ptrendx
ptrendx approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptrendx ptrendx merged commit c16aa91 into apache:v1.8.x Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@samskalicky samskalicky samskalicky approved these changes

@ptrendx ptrendx ptrendx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kh4L @mxnet-bot @samskalicky @ptrendx @lanking520