Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@josephevans
Copy link
Contributor

Description

Fixes the following export functions by casting the input and output to the proper data types:

  • broadcast_logical_and
  • broadcast_logical_or
  • broadcast_logical_xor
  • logical_not

Adds unit tests for the following ONNX export operators:

  • reciprocal
  • _power
  • broadcast_power
  • sqrt
  • depth_to_space
  • space_to_depth
  • square
  • shape_array
  • hard_sigmoid
  • broadcast_lesser
  • broadcast_greater
  • broadcast_logical_and
  • broadcast_logical_or
  • broadcast_logical_xor
  • logical_not
  • log_softmax
  • broadcast_to

@josephevans josephevans requested a review from szha as a code owner April 19, 2021 22:13
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, unix-gpu, website, centos-cpu, miscellaneous, edge, clang, sanity, windows-cpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-review PR is waiting for code review label Apr 20, 2021
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zha0q1 Zha0q1 merged commit 94fe808 into apache:v1.x Apr 21, 2021
@josephevans josephevans deleted the onnx_op_tests_v1.x branch April 21, 2021 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants