Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@bgawrych
Copy link
Contributor

Description

This is implementation of RFC #19361 and connected with issue #19218

>>> import mxnet as mx
>>> mx.nd.array([9e-45])

[0.]
<NDArray 1 @cpu(0)>
>>> mx.util.set_flush_denorms(False)
>>> mx.nd.array([9e-45])

[8.e-45]
<NDArray 1 @cpu(0)>
>>> mx.util.set_flush_denorms(True)
>>> mx.nd.array([9e-45])

[0.]
<NDArray 1 @cpu(0)>
>>> exit

As stated in RFC handling denormalized values is enabled by default and API for changing this behavior is available for the user

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • [] All changes have test coverage
  • Code is well-documented

B. Gawrych and others added 4 commits June 9, 2021 07:59
@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, centos-gpu, clang, windows-gpu, edge, sanity, miscellaneous, unix-cpu, website, windows-cpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 14, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-gpu, windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, windows-gpu, centos-gpu, windows-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 14, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Jun 15, 2021

Hey @szha,
enabling FTZ and DAZ introduces CI fail in test_numpy_interoperability.py::test_np_array_ufunc_protocol

Problematic function is remainder and I'm not sure how this should be handled - should it be disabling FTZ for this test, editing workload or maybe something different?

image

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 23, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, sanity, website, clang, centos-cpu, unix-cpu, centos-gpu, unix-gpu, edge, windows-cpu, miscellaneous]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 1, 2021
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few nits above on the documentation the change looks good to me. Thanks!

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 2, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Jul 5, 2021

@mxnet-bot run ci [unix-gpu, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 5, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 16, 2021
@akarbown akarbown merged commit aeff388 into apache:v1.x Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants