Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Updated v1.x to version 1.10 after branching v1.9.x #20348

Open
Kh4L wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

[v1.x] Updated v1.x to version 1.10 after branching v1.9.x #20348

Kh4L wants to merge 1 commit into from

Conversation

@Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Jun 14, 2021

Description

Updated v1.x to version 1.9 after branching v1.8.x. Followed previous update PR #19196

@mxnet-bot
Copy link

mxnet-bot commented Jun 14, 2021

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, sanity, edge, clang, website, windows-gpu, unix-gpu, centos-gpu, windows-cpu, unix-cpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 14, 2021
@Kh4L Kh4L changed the title Updated v1.x to version 1.10 after branching v1.9.x [v1.x] Updated v1.x to version 1.10 after branching v1.9.x Jun 14, 2021
@Kh4L
Copy link
Contributor Author

Kh4L commented Jun 23, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jun 23, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 23, 2021
@szha
Copy link
Member

szha commented Feb 5, 2022

You haven't bumped the version number in c header. Please find and refer to earlier PRs on version bumping to see what to do.

@Kh4L
Updated v1.x to version 1.10 after branching v1.9.x
8f372d4 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Copy link
Contributor Author

Kh4L commented Feb 16, 2022

You haven't bumped the version number in c header. Please find and refer to earlier PRs on version bumping to see what to do.

Good catch, thanks!

Done

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 16, 2022
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Mar 14, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Mar 14, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 9, 2022
@josephevans
Copy link
Contributor

josephevans commented Apr 14, 2022

Is this ready for merge? @szha

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 4, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@gigasquid gigasquid Awaiting requested review from gigasquid gigasquid is a code owner

@iblislin iblislin Awaiting requested review from iblislin

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@thirdwing thirdwing Awaiting requested review from thirdwing thirdwing is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

1 more reviewer

@josephevans josephevans josephevans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-testing PR is reviewed and waiting CI build and test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kh4L @mxnet-bot @szha @josephevans @mseth10