Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] [Backport] Add checks in batchnorm's infer shape #20444

Merged
akarbown merged 3 commits into from
Aug 13, 2021
Merged

[v1.x] [Backport] Add checks in batchnorm's infer shape #20444

akarbown merged 3 commits into from
Aug 13, 2021

Conversation

@bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Jul 12, 2021

Description

Add checks to infer shape to avoid passing invalid tensors. Connected to issue: #19065

Backport of: #20415

@mxnet-bot
Copy link

mxnet-bot commented Jul 12, 2021

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, clang, unix-cpu, miscellaneous, centos-cpu, edge, sanity, centos-gpu, windows-gpu, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 12, 2021
@bgawrych bgawrych requested a review from anirudh2290 as a code owner July 21, 2021 06:38
@bgawrych bgawrych force-pushed the backport_bn_infer_fix branch from 0f7b51b to 3ce2ef2 Compare July 21, 2021 07:16
@szha
Copy link
Member

szha commented Aug 1, 2021

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

mxnet-bot commented Aug 1, 2021

Jenkins CI successfully triggered : [website, clang, windows-gpu, unix-gpu, sanity, unix-cpu, windows-cpu, centos-gpu, miscellaneous, centos-cpu, edge]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 1, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Aug 9, 2021

@mxnet-bot run ci [centos-gpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 9, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Aug 9, 2021
bartekkuncer
bartekkuncer suggested changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply formatter to the changed code.

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 9, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Aug 10, 2021 •
edited
Loading

Please apply formatter to the changed code.

Done for my changes - for whole files (src/operator/nn/batch_norm.cc and tests/cpp/operator/batchnorm_test.cc) probably would be better to make it in other commit with more formatting changes

@bgawrych
Copy link
Contributor Author

bgawrych commented Aug 10, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 10, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Aug 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 10, 2021
bartekkuncer
bartekkuncer approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akarbown akarbown merged commit 22f927a into apache:v1.x Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

2 more reviewers

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@akarbown akarbown akarbown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bgawrych @mxnet-bot @szha @bartekkuncer @akarbown @mseth10