Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[CI] Fix centos CI & website build #20512

Merged
szha merged 4 commits into from
Aug 12, 2021
Merged

[CI] Fix centos CI & website build #20512

szha merged 4 commits into from
Aug 12, 2021

Conversation

@barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Aug 10, 2021 •
edited
Loading

Description

  1. Fix CI CentOS-GPU tests failed #20494
  2. Disable ssl verfication in link check & fix links redirect to 404

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Aug 10, 2021

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, unix-gpu, miscellaneous, centos-gpu, unix-cpu, sanity, website, windows-cpu, clang, centos-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 10, 2021
@szha
Copy link
Member

szha commented Aug 11, 2021

@mxnet-bot run ci [centos-cpu, centos-gpu, miscellaneous, unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 11, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, miscellaneous, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 11, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 11, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 11, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 11, 2021
@barry-jin barry-jin requested a review from marcoabreu as a code owner August 12, 2021 04:02
@barry-jin barry-jin changed the title [DOC] Disable ssl verfication in link check & fix links redirect to 404 [CI] Fix centos CI & website build Aug 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 12, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Aug 12, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 12, 2021

@mxnet-bot run ci [centos-cpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 12, 2021

Jenkins CI successfully triggered : [unix-gpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 12, 2021
mozga-intel
mozga-intel reviewed Aug 12, 2021
View reviewed changes
docs/python_docs/python/scripts/conf.py
numpydoc_show_class_members = False

# Disable SSL verification in link check.
tls_verify = False
Copy link
Contributor

@mozga-intel mozga-intel Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does tls_verify is a GitLab Runner configuration? Shouldn't the tls_verify be disabled by default? Following the doc

tls_verify Enable or disable TLS verification of connections to Docker daemon. Disabled by default.

Copy link
Contributor Author

@barry-jin barry-jin Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a configuration in sphinx to disable verifying the server certifications.
ref: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-tls_verify

@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 12, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 12, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 12, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 12, 2021

@TristonC @szha Could you help review this PR. It should unblock centOS and website build tests in master branch.

@szha szha merged commit f70a695 into apache:master Aug 12, 2021
@barry-jin barry-jin deleted the link-check2 branch August 12, 2021 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu

1 more reviewer

@mozga-intel mozga-intel mozga-intel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI CentOS-GPU tests failed

5 participants

@barry-jin @mxnet-bot @szha @mozga-intel @mseth10