Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix scale bug in quantized batch_dot #20735

Merged
bgawrych merged 1 commit into from
Nov 17, 2021
Merged

Fix scale bug in quantized batch_dot #20735

bgawrych merged 1 commit into from
Nov 17, 2021

Conversation

@DominikaJedynak
Copy link
Contributor

@DominikaJedynak DominikaJedynak commented Nov 10, 2021

Description

Small fixes:

  • corrected mistake by changing min_calib_range to max_calib_range
  • deleted repeated comment

@mxnet-bot
Copy link

mxnet-bot commented Nov 10, 2021

Hey @DominikaJedynak , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, clang, edge, centos-cpu, windows-gpu, website, sanity, unix-gpu, miscellaneous, centos-gpu, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 10, 2021
@DominikaJedynak DominikaJedynak changed the title Small fix Fix scale bug in quantized batch_dot Nov 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 10, 2021
@DominikaJedynak
Copy link
Contributor Author

DominikaJedynak commented Nov 10, 2021

@mxnet-bot run ci [miscellaneous, unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Nov 10, 2021

Jenkins CI successfully triggered : [miscellaneous, website, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 10, 2021
@DominikaJedynak
Copy link
Contributor Author

DominikaJedynak commented Nov 12, 2021

@mxnet-bot run ci [miscellaneous, unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Nov 12, 2021

Jenkins CI successfully triggered : [unix-gpu, website, miscellaneous]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 12, 2021
@DominikaJedynak
Copy link
Contributor Author

DominikaJedynak commented Nov 12, 2021

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Nov 12, 2021

Jenkins CI successfully triggered : [unix-gpu, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 12, 2021
@DominikaJedynak
Copy link
Contributor Author

DominikaJedynak commented Nov 12, 2021

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Nov 12, 2021

Jenkins CI successfully triggered : [website, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 12, 2021
@bgawrych
Copy link
Contributor

bgawrych commented Nov 17, 2021

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Nov 17, 2021

Jenkins CI successfully triggered : [unix-gpu, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 17, 2021
@bgawrych bgawrych merged commit 52bc1bf into apache:master Nov 17, 2021
@DominikaJedynak DominikaJedynak deleted the min-max-fix branch November 18, 2021 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DominikaJedynak @mxnet-bot @bgawrych @bartekkuncer @mseth10