Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Feature] Add bfloat to oneDNN version of binary broadcast operators. #20846

Merged
bgawrych merged 3 commits into from
Feb 11, 2022
Merged

[Feature] Add bfloat to oneDNN version of binary broadcast operators. #20846

bgawrych merged 3 commits into from
Feb 11, 2022

Conversation

@agrabows
Copy link
Contributor

@agrabows agrabows commented Jan 25, 2022

Description

Binary broadcast operators such as broadcast_add are supported by oneDNN but not when inputs are of type bFloat16. Goal was to add those cases.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

mxnet-bot commented Jan 25, 2022

Hey @agrabows , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, unix-cpu, windows-gpu, centos-gpu, clang, website, edge, unix-gpu, sanity, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 25, 2022
@agrabows
Copy link
Contributor Author

agrabows commented Jan 26, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 26, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 26, 2022
@agrabows
Copy link
Contributor Author

agrabows commented Jan 27, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 27, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 27, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 1, 2022
@agrabows
Copy link
Contributor Author

agrabows commented Feb 2, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Feb 2, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 2, 2022
bgawrych
bgawrych reviewed Feb 2, 2022
View reviewed changes
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 2, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 7, 2022
@agrabows
Copy link
Contributor Author

agrabows commented Feb 8, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Feb 8, 2022

Jenkins CI successfully triggered : [windows-gpu]

@agrabows
Copy link
Contributor Author

agrabows commented Feb 8, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Feb 8, 2022

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 8, 2022
@agrabows
Copy link
Contributor Author

agrabows commented Feb 8, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Feb 8, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 8, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2022
@bgawrych bgawrych merged commit fadfaee into apache:master Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@anko-intel anko-intel anko-intel approved these changes

@bgawrych bgawrych bgawrych approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@agrabows @mxnet-bot @anko-intel @bgawrych @bartekkuncer @mseth10 @agrabow