This repository was archived by the owner on Nov 17, 2023. It is now read-only.
__neg__ should return new array instead of changing self#213
Merged
tqchen merged 1 commit intoapache:masterfrom Oct 6, 2015
pluskid:master
Merged
__neg__ should return new array instead of changing self#213tqchen merged 1 commit intoapache:masterfrom pluskid:master
tqchen merged 1 commit intoapache:masterfrom
pluskid:master
Conversation
Member
|
I think this is something we need to fix |
tqchen
added a commit
that referenced
this pull request
Oct 6, 2015
__neg__ should return new array instead of changing self
iblislin
pushed a commit
to iblislin/incubator-mxnet
that referenced
this pull request
Mar 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure it was a bug or intentional design. I believe the
__neg__function should not change contents ofself. Instead, it should return a new array. It is really weird if after executing, say,x += -grad, the contents ofgradis negated.