Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Comments

Add deconvolution operator, and the corresponding implement using cudnn_v3#422

Merged
antinucleon merged 12 commits intoapache:masterfrom
tornadomeet:master
Oct 30, 2015
Merged

Add deconvolution operator, and the corresponding implement using cudnn_v3#422
antinucleon merged 12 commits intoapache:masterfrom
tornadomeet:master

Conversation

@tornadomeet
Copy link
Contributor

  1. have done a simple deconvolution_shape_check;
  2. when using deconvolution layer, the mxnet's implemention and cudnn's implemention give the same output almostly. using the follow example: replace one line of the example/mnist/lenet.py , refer to deconv_lenet.py

@tornadomeet tornadomeet changed the title Add deconvolution operator, and the corressing implement using cudnn_v3 Add deconvolution operator, and the corresponding implement using cudnn_v3 Oct 29, 2015
@antinucleon
Copy link
Contributor

Thanks for the great PR! Could you fix the lint?

@antinucleon
Copy link
Contributor

You can try make lint to see the lint result locally.

@tornadomeet
Copy link
Contributor Author

fix lint now.

@antinucleon
Copy link
Contributor

Thanks! Another issue is could you add namespace for enum? for example https://github.com/dmlc/mxnet/blob/master/src/operator/convolution-inl.h#L24 . Because we will soon provide amalgamation version code, this part will make name conflict..

@tornadomeet
Copy link
Contributor Author

i'll add these and check now.

@tornadomeet
Copy link
Contributor Author

now have added the namespace for deconvolution-inl.h and cudnn_deconvolution-inl.h.

@mli
Copy link
Contributor

mli commented Oct 30, 2015

thanks for the PR! but what does deconvolution do? in my understanding it can be used to reserve a convolution layer and used for visualization. but in your lenet example, you just replace the conv layer by deconv layer for training?

@tornadomeet
Copy link
Contributor Author

deconvolution mostly used for upsampling, for example, in image segmentation, can refer fcn-xs, deconvnet, crfasrnn.
the lenet example here is just for unitest, and i'm implenmenting the fcn-xs in mxnet now, but not very soon.

@mli
Copy link
Contributor

mli commented Oct 30, 2015

@tornadomeet very helpful, thanks!

@antinucleon
Copy link
Contributor

Last thing, could you add your name in Contributor.md? then I will merge it

antinucleon added a commit that referenced this pull request Oct 30, 2015
Add deconvolution operator, and the corresponding implement using cudnn_v3
@antinucleon antinucleon merged commit c2727a2 into apache:master Oct 30, 2015
@tornadomeet
Copy link
Contributor Author

ok, i have added my name now.

iblislin added a commit to iblislin/incubator-mxnet that referenced this pull request Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants