This repository was archived by the owner on Nov 17, 2023. It is now read-only.
set __layout__ attribute for FusedRNNCell output states#6747
Merged
piiswrong merged 2 commits intoapache:masterfrom Jun 20, 2017
formath:master
Merged
set __layout__ attribute for FusedRNNCell output states#6747piiswrong merged 2 commits intoapache:masterfrom formath:master
piiswrong merged 2 commits intoapache:masterfrom
formath:master
Conversation
Contributor
|
Thanks |
Contributor
|
This should be done in _normalize_sequence |
Contributor
|
Actually, I think this commit's approach is better: c1fd788 swapping contradicts state_info |
Contributor
Author
|
Yes. So I have reverted it. |
Guneet-Dhillon
pushed a commit
to Guneet-Dhillon/mxnet
that referenced
this pull request
Sep 13, 2017
* set __layout__ attr for FucedRNNCell output states * right usage not that in desc
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6736
In
FusedRNNCell, default layoutN...is not possible for its output states which should be 'LNC'.@piiswrong