This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Scala] support str key type in kvstore #6811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhliu
reviewed
Jun 26, 2017
| len: MXUint, | ||
| keys: Array[String], | ||
| values: Array[NDArrayHandle], | ||
| priority: Int): Int |
Member
There was a problem hiding this comment.
please align the argument indent. same for mxKVStorePullEx
Member
|
LGTM. Could you help to check why jenkins test failed? I cannot open the link. @piiswrong |
Contributor
|
I can't open either. Something is wrong with this PR. Maybe close and open another |
Contributor
Author
|
close and open another one |
Contributor
Author
|
move to #6828 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #6765
@Javelinjs would you help to review ?