This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Make sure build_doc only builds target version#9900
Merged
marcoabreu merged 1 commit intoapache:masterfrom Feb 27, 2018
Merged
Conversation
Contributor
Author
|
Due to this being a release blocker, I'm executing a self merge |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_doc attempts to try building the passed version as well as master, resulting in two builds.
The target of this script is to build only exactly one version - the passed tag OR the master. The current design is not able to handle multiple builds as "make docs" pollutes the directory. While it might be feasible to clean it up, I don't think it's necessary because this script only build the target version and nothing else.