Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

workaround for install page display issue#9902

Merged
marcoabreu merged 1 commit intoapache:masterfrom
aaronmarkham:install_patch
Feb 28, 2018
Merged

workaround for install page display issue#9902
marcoabreu merged 1 commit intoapache:masterfrom
aaronmarkham:install_patch

Conversation

@aaronmarkham
Copy link
Copy Markdown
Contributor

Description

Disables the versions dropdown on the install page when the dropdown is being injected. This is a temporary workaround while we can find a better solution for the display problems.

Background

The versions dropdown is injected in post build processing and this step breaks the page causing the wrong divs to be displayed.

@aaronmarkham aaronmarkham requested a review from szha as a code owner February 27, 2018 17:52
@szha
Copy link
Copy Markdown
Member

szha commented Feb 27, 2018

The updated page looks like this http://mxnet-doc.s3-accelerate.dualstack.amazonaws.com/PR-9902/install/index.html. Unfortunately I haven't figured out how to try the version dropdown in a local build yet.

@kevinthesun
Copy link
Copy Markdown
Contributor

kevinthesun commented Feb 27, 2018

@aaronmarkham Have you tried to directly pull https://github.com/apache/incubator-mxnet-site and debug locally? This can help you locate the issue more easily.

@marcoabreu
Copy link
Copy Markdown
Contributor

Merging as a workaround. A proper fix should be submitted asap

@marcoabreu marcoabreu merged commit 48749a5 into apache:master Feb 28, 2018
@aaronmarkham aaronmarkham deleted the install_patch branch March 27, 2018 01:36
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants