Automatically import types when selected on code completion

[stollr]

Description

Almost every time I am using Netbeans I am missing the automatic import of types when I select them from code completion.

To make it clear I would like to provide some screenshots. The first one shows how Netbeans suggests a class:

This works great. Now I select the suggested type by hitting enter:

As you see in the screenshot the full qualified class name is inserted.

But usually I want the class to be added as import and only the class name to be inserted at the caret's position.
So the result should look like this:

To be considered

Before Netbeans inserts the import, it has to check if the type already is imported or if there is already another type imported with the same name but different namespace. In the latter case it might insert the full qualified class name (like today).

Use case/motivation

The current situation requires some manual work for each code completion, when working with namespace.

Related issues

No response

Are you willing to submit a pull request?

No

[junichi11]

As an old issue: https://bz.apache.org/netbeans/show_bug.cgi?id=270083

[junichi11]

@stollr It would be nice if you can test it with the dev version: https://github.com/apache/netbeans/suites/20437665071/artifacts/1219370144

[stollr]

Thanks for your work on this. To enable this behaviour one has to check "Auto import" in Options -> Editor -> Code Completion -> Language [PHP].

I'd suggest to add a separate checkbox instead of a fourth type of code completion which could be checked to enable automatic import for smart and unqualified code completion. Because both of these types may benefit from the automatic import.

I have tried to create an example how this could look like:

And please enable this option per default, because it is very likely that most of the users will use this option ;-)

Apart from that, the feature works well. I have only one notice:

If the class has a doc block. The import statement is placed between the doc block and the class definition. Better would be, if the import is added below the namespace declaration or at the beginning of the file if there is no namespace declaration.

What do you think?

[junichi11]

@stollr Thank you for testing it! I'll improve a bit.