Bugfix: Go To source broken for nested classes.#3189
Conversation
ratcashdev
force-pushed
the
bugfix/jira-6041
branch
from
3d20e67 to
8355077
Compare
mbien
added
Java
|
added milestone NB14 to keep this on the radar. |
|
NB14? ...been waiting for 4 months. Could have been included already in 12.6 |
probably, but nobody reviewed it yet unfortunately. NB14 is the next realistic milestone, NB13 would be still possible in theory but this would have to get reviewed quickly and rebased on top of the delivery branch since NB13 is in the rc phase. If you really want to get a PR in and see no activity here, dropping a mail to the dev list can sometimes help to get some eyes on it. Thanks for sticking around. |
|
will do next time. Tried to make it clear in the jira ticket that there's a PR, but that, apparently, was left unattended too. |
|
I'm sorry, I've totally missed this one. |
lkishalmi
force-pushed
the
bugfix/jira-6041
branch
from
8355077 to
ab0e8cc
Compare
lkishalmi
force-pushed
the
bugfix/jira-6041
branch
from
ab0e8cc to
6a00304
Compare
|
Well, updated this one from master, documented the API changes. Let's see what CI is telling about this one. |
| */ | ||
| public static Location parseCanonicalLocation(String loc) { | ||
| if (loc == null) { | ||
| return new Location(null, null, null); |
There was a problem hiding this comment.
Are we expecting null as an argument?
wouldn't be better to throw an NPE, or just do an assert loc != null;
Or return a null instead of a Location.
| if ((first != null) && (first instanceof GradleTestMethodNode)) { | ||
| GradleTestMethodNode node = (GradleTestMethodNode) first; | ||
| Location loc = new Location(node.getTestLocation().getFileName()); | ||
| Location loc = node.getTestLocation().withNoTarget(); |
There was a problem hiding this comment.
Is this with tab characters? I hope you are not using tabs to indent the source code.
There was a problem hiding this comment.
Well, yes. With today's merge tools and their ability to hide whitespace, formatting became much less of a concern for me.
Thanks for putting it into shape and merging. So this is... for 14. Do you think it is compatible with 13 too?
|
@lkishalmi do you think this can be built out of the current master and dropped into 13.0 as a jar? |
|
Not really. Though you can try to build nbm-s out of the gradle,java and gradle.junit modules, though you may need to build the gradle main module as well. |
3 participants
This PR is part of the fixes needed for https://issues.apache.org/jira/browse/NETBEANS-6041
This is a fix for gradle projects, but since it's also broken for MAVEN (and possible standard netbeans projects) might need to be refactored to a different common module to fix it everywhere at once. Not sure what would be the best place.