Skip to content

Replaced usage of String.to[U/L]Case() with String.equalsIgnoreCase() #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbien merged 1 commit into from
Feb 17, 2023
Merged

Replaced usage of String.to[U/L]Case() with String.equalsIgnoreCase() #5219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/GlassFishSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public static boolean showWindowSystem() {
String showProperty
= System.getProperty("org.netbeans.core.WindowSystem.show");
return showProperty == null
|| !showProperty.toLowerCase().equals("false");
|| !showProperty.equalsIgnoreCase("false");
}

}
2 changes: 1 addition & 1 deletion enterprise/payara.common/src/org/netbeans/modules/payara/common/PayaraSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public static boolean showWindowSystem() {
String showProperty
= System.getProperty("org.netbeans.core.WindowSystem.show");
return showProperty == null
|| !showProperty.toLowerCase().equals("false");
|| !showProperty.equalsIgnoreCase("false");
}

}
4 changes: 2 additions & 2 deletions enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/TomcatInstallUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ public static void updateDocument(final javax.swing.text.Document doc,

private static boolean isHttpConnector(String protocol, String scheme, String secure) {
return (protocol == null || protocol.length() == 0 || protocol.toLowerCase().startsWith(HTTP))
&& (scheme == null || !scheme.toLowerCase().equals(HTTPS))
&& (secure == null || !secure.toLowerCase().equals(TRUE));
&& (scheme == null || !scheme.equalsIgnoreCase(HTTPS))
&& (secure == null || !secure.equalsIgnoreCase(TRUE));
}

public static boolean setServerPort(int port, File tomcatConf) {
Expand Down
2 changes: 1 addition & 1 deletion enterprise/web.jsf/src/org/netbeans/modules/web/jsf/wizards/ManagedBeanIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public Set instantiate(TemplateWizard wizard) throws IOException {
break;
}
} else {
if (targetName.equalsIgnoreCase(beanName) && targetName.substring(0, 1).toLowerCase().equals(beanName.substring(0, 1))) {
if (targetName.equalsIgnoreCase(beanName) && targetName.substring(0, 1).equalsIgnoreCase(beanName.substring(0, 1))) {
templateProperties.put("classAnnotation", "@ManagedBean"); //NOI18N
} else {
templateProperties.put("classAnnotation", "@ManagedBean(name=\"" + beanName + "\")"); //NOI18N
Expand Down
4 changes: 2 additions & 2 deletions groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/MethodCompletion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ private List<String> getTypesInSameFile() {
*/
private boolean exactConstructorExists(List<? extends Element> typelist, String prefix) {
for (Element element : typelist) {
if (prefix.toUpperCase().equals(element.getSimpleName().toString().toUpperCase())) {
if (prefix.equalsIgnoreCase(element.getSimpleName().toString())) {
return true;
}
}
Expand All @@ -294,7 +294,7 @@ private void addExactProposals(FileObject source, List<? extends Element> typeli
// all the constructors are named <init>.
String constructorName = element.getSimpleName().toString();

if (constructorName.toUpperCase().equals(context.getPrefix().toUpperCase())) {
if (constructorName.equalsIgnoreCase(context.getPrefix())) {
addConstructorProposal(tel.getQualifiedName().toString(), (ExecutableElement) encl);
}
}
Expand Down
2 changes: 1 addition & 1 deletion groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/TypesCompletion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ private void addToProposalUsingFilter(Set<TypeHolder> alreadyPresent, TypeHolder
// If we are in situation: "String s = new String|" we don't want to show
// String type as a option - we want to show String constructors + types
// prefixed with String (e.g. StringBuffer)
if (constructorCompletion && typeName.toUpperCase().equals(request.getPrefix().toUpperCase())) {
if (constructorCompletion && typeName.equalsIgnoreCase(request.getPrefix())) {
return;
}

Expand Down
6 changes: 3 additions & 3 deletions ide/bugzilla/src/org/netbeans/modules/bugzilla/issue/IssuePanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ private String findInModel(JComboBox combo, String value) {
ComboBoxModel model = combo.getModel();
for(int i = 0; i < model.getSize(); i++) {
String element = model.getElementAt(i).toString();
if(value.toLowerCase().equals(element.toString().toLowerCase())) {
if(value.equalsIgnoreCase(element)) {
return element;
}
}
Expand Down Expand Up @@ -3011,7 +3011,7 @@ private boolean productChanged(boolean reload) {
List<String> versions = repository.getConfiguration().getVersions(product);
String defaultVersion = getCurrentNetBeansVersion();
for (String v : versions) {
if (v.trim().toLowerCase().equals(defaultVersion.toLowerCase())) {
if (v.trim().equalsIgnoreCase(defaultVersion)) {
issue.setFieldValue(IssueField.VERSION, v);
}
}
Expand Down Expand Up @@ -3727,7 +3727,7 @@ void makeCaretVisible(JTextArea textArea) {
private String getCurrentNetBeansVersion() {
String version = parseProductVersion(getProductVersionValue());
if(version != null) {
if(version.toLowerCase().equals("dev")) { // NOI18N
if(version.equalsIgnoreCase("dev")) { // NOI18N
return CURRENT_NB_VERSION;
} else {
return version;
Expand Down
2 changes: 1 addition & 1 deletion ide/bugzilla/src/org/netbeans/modules/bugzilla/query/QueryParameter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public void setValues(ParameterValue[] values) {
// need case sensitive compare
for(int j = 0; j < model.getSize(); j++) {
ParameterValue pv = (ParameterValue) model.getElementAt(j);
if(pv.getValue().toLowerCase().equals(values[i].getValue().toLowerCase())) {
if(pv.getValue().equalsIgnoreCase(values[i].getValue())) {
selectionList.add(j);
break;
}
Expand Down
4 changes: 2 additions & 2 deletions ide/css.editor/src/org/netbeans/modules/css/editor/module/spi/CompletionContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public Node getNodeForNonWhiteTokenBackward() {
//empty file
return getParseTreeRoot();
}
if(!CssTokenIdCategory.WHITESPACES.name().toLowerCase().equals(t.id().primaryCategory())) {
if(!CssTokenIdCategory.WHITESPACES.name().equalsIgnoreCase(t.id().primaryCategory())) {
return NodeUtil.findNonTokenNodeAtOffset(getParseTreeRoot(), ts.offset() + t.length());
} else {
if(!ts.movePrevious()) {
Expand Down Expand Up @@ -175,7 +175,7 @@ public CssTokenId getNonWhiteTokenIdBackward() {
//empty file
return null;
}
if(!CssTokenIdCategory.WHITESPACES.name().toLowerCase().equals(t.id().primaryCategory())) {
if(!CssTokenIdCategory.WHITESPACES.name().equalsIgnoreCase(t.id().primaryCategory())) {
return t.id();
} else {
if(!ts.movePrevious()) {
Expand Down
2 changes: 1 addition & 1 deletion ide/db.core/src/org/netbeans/modules/db/sql/execute/SQLExecuteHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ private boolean isToken(String token) {
return false;
}

if ( substr.toUpperCase().equals(token.toUpperCase())) { // NOI18N
if ( substr.equalsIgnoreCase(token)) { // NOI18N
return true;
}

Expand Down
4 changes: 2 additions & 2 deletions ide/db.core/src/org/netbeans/modules/db/sql/history/SQLHistoryEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ public boolean equals(Object obj) {
return false;
}
final SQLHistoryEntry other = (SQLHistoryEntry) obj;
if ((this.url == null) ? (other.url != null) : !this.url.toLowerCase().equals(other.url.toLowerCase())) {
if ((this.url == null) ? (other.url != null) : !this.url.equalsIgnoreCase(other.url)) {
return false;
}
if ((this.sql == null) ? (other.sql != null) : !this.sql.toLowerCase().equals(other.sql.toLowerCase())) {
if ((this.sql == null) ? (other.sql != null) : !this.sql.equalsIgnoreCase(other.sql)) {
return false;
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion ide/db.sql.visualeditor/src/org/netbeans/modules/db/sql/visualeditor/Log.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private Logger getPackageLogger() {
if (logger == null) {
String prop = System.getProperty(packageName, DEFAULT_NAME);
for (int i = 1; i < LEVELS.length; i++) {
if (prop.toLowerCase().equals(LEVEL_NAMES[i].toLowerCase())) {
if (prop.equalsIgnoreCase(LEVEL_NAMES[i])) {
level = LEVELS[i];
break;
}
Expand Down
2 changes: 1 addition & 1 deletion ide/db/src/org/netbeans/modules/db/explorer/DatabaseConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public TableColumn getColumnSpecification(Table table, Column column) throws Dat
col.setColumnSize(0);
}

col.setNullAllowed((rset.get(Integer.valueOf(18))).toUpperCase().equals("YES")); //NOI18N
col.setNullAllowed((rset.get(Integer.valueOf(18))).equalsIgnoreCase("YES")); //NOI18N
col.setDefaultValue(rset.get(Integer.valueOf(13)));
rset.clear();
} else {
Expand Down
8 changes: 4 additions & 4 deletions ide/db/test/unit/src/org/netbeans/modules/db/test/DBTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ protected TableNode getTableNode(String tablename) throws Exception {
// DatabaseNodeInfo.printChildren("tables", tables);

for (Node table : tables) {
if (tablename.toLowerCase().equals(table.getDisplayName().toLowerCase())) {
if (tablename.equalsIgnoreCase(table.getDisplayName())) {
return (TableNode)table;
}
}
Expand All @@ -189,7 +189,7 @@ protected TableNode getTableNode(String tablename) throws Exception {
// DatabaseNodeInfo.printChildren("tables", tables);

for (Node table : tables) {
if (tablename.toLowerCase().equals(table.getDisplayName().toLowerCase())) {
if (tablename.equalsIgnoreCase(table.getDisplayName())) {
return (TableNode)table;
}
}
Expand Down Expand Up @@ -224,7 +224,7 @@ protected ViewNode getViewNode(String viewname) throws Exception {
// DatabaseNodeInfo.printChildren("tables", tables);

for (Node view : views) {
if (viewname.toLowerCase().equals(view.getDisplayName().toLowerCase())) {
if (viewname.equalsIgnoreCase(view.getDisplayName())) {
return (ViewNode)view;
}
}
Expand All @@ -237,7 +237,7 @@ protected ViewNode getViewNode(String viewname) throws Exception {
// DatabaseNodeInfo.printChildren("tables", tables);

for (Node view : views) {
if (viewname.toLowerCase().equals(view.getDisplayName().toLowerCase())) {
if (viewname.equalsIgnoreCase(view.getDisplayName())) {
return (ViewNode)view;
}
}
Expand Down
2 changes: 1 addition & 1 deletion ide/db/test/unit/src/org/netbeans/modules/db/test/DefaultDBProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public boolean schemaExists(Connection conn, String schemaName) throws Exception
ResultSet rs = md.getSchemas();

while ( rs.next() ) {
if ( schemaName.toLowerCase().equals(rs.getString(1).toLowerCase())) {
if ( schemaName.equalsIgnoreCase(rs.getString(1))) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion ide/dlight.nativeexecution/src/org/netbeans/modules/nativeexecution/api/util/Path.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public static String getPathName() {
if (pathName == null) {
if (Utilities.isWindows()) {
for (String key : System.getenv().keySet()) {
if (key.toLowerCase().equals("path")) { // NOI18N
if (key.equalsIgnoreCase("path")) { // NOI18N
pathName = key.substring(0, 4);
return pathName;
}
Expand Down
8 changes: 4 additions & 4 deletions ide/editor/test/qa-functional/src/org/netbeans/jellytools/modules/editor/KeyMapOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public Vector<String> getAllShortcutsForAction(String actionName) {
String _scStr;
for (int i = 0; i < tm.getRowCount(); i++) {
_str = tm.getValueAt(i, 0).toString();
if (_str.toLowerCase().equals(actionName.toLowerCase()) || _str.toLowerCase().equals(actionName.toLowerCase() + " (alternative shortcut)")) {
if (_str.equalsIgnoreCase(actionName) || _str.equalsIgnoreCase(actionName + " (alternative shortcut)")) {
_scStr = tm.getValueAt(i, 1).toString().toLowerCase();
lstr.add(_scStr);
System.out.println("[TEST_DEBUG] -> found action \"" + _str + "\" with shortcut " + _scStr);
Expand Down Expand Up @@ -192,7 +192,7 @@ public boolean assignShortcutToAction(String actionName, boolean ctrl, boolean s
for (int i = 0; i < tab.getRowCount(); i++) {
_str = tm.getValueAt(i, 0).toString();
System.out.println("[TEST_DEBUG] Examining action \"" + _str + "\", which is no. " + (i + 1) + " in the table...");
if (_str.toLowerCase().equals(actionName.toLowerCase())) {
if (_str.equalsIgnoreCase(actionName)) {
System.out.println("[TEST_DEBUG] -> action \"" + _str + "\" (" + actionName + ") was found");
sleep(100);
tab.clickForEdit(i, 1);
Expand Down Expand Up @@ -232,7 +232,7 @@ public boolean assignAlternativeShortcutToAction(String actionName, boolean ctrl
for (int i = 0; i < tab.getRowCount(); i++) {
_str = tm.getValueAt(i, 0).toString();
System.out.println("[TEST_DEBUG] Examining action " + _str + ", which is no. " + (i + 1) + "in the table...");
if (_str.toLowerCase().equals(actionName.toLowerCase())) {
if (_str.equalsIgnoreCase(actionName)) {
System.out.println("[TEST_DEBUG] Action " + actionName + "was found");
JListOperator jli = clickShortcutEllipsisButton(tab, i);
retval = true;
Expand Down Expand Up @@ -271,7 +271,7 @@ public boolean unassignAlternativeShortcutToAction(String actionName, String sho
for (int i = 0; i < tab.getRowCount(); i++) {
_str = tm.getValueAt(i, 0).toString();
System.out.println("[TEST_DEBUG] Examining action " + _str + ", which is no. " + (i + 1) + "in the table...");
if (_str.toLowerCase().startsWith(actionName.toLowerCase()) && tm.getValueAt(i, 1).toString().toLowerCase().equals(shortcutStr.toLowerCase())) {
if (_str.toLowerCase().startsWith(actionName.toLowerCase()) && tm.getValueAt(i, 1).toString().equalsIgnoreCase(shortcutStr)) {
System.out.println("[TEST_DEBUG] Action " + actionName + "was found");
JListOperator jli = clickShortcutEllipsisButton(tab, i);
jli.clickOnItem("Clear");
Expand Down
2 changes: 1 addition & 1 deletion ide/subversion/src/org/netbeans/modules/subversion/client/SvnClientInvocationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public Object run () throws Exception {
} catch (SSLKeyException ex) {
if(ex.getCause() instanceof InvalidKeyException) {
InvalidKeyException ike = (InvalidKeyException) ex.getCause();
if(ike.getMessage().toLowerCase().equals("illegal key size or default parameters")) { // NOI18N
if(ike.getMessage().equalsIgnoreCase("illegal key size or default parameters")) { // NOI18N
SvnClientExceptionHandler.handleInvalidKeyException(ike);
}
return null;
Expand Down
14 changes: 7 additions & 7 deletions ide/terminal.nb/src/org/netbeans/modules/terminal/ioprovider/Terminal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,19 +586,19 @@ private void applyDebugFlags() {
StringTokenizer st = new StringTokenizer(value, ","); // NOI18N
while (st.hasMoreTokens()) {
String s = st.nextToken();
if (s.toLowerCase().equals("ops")) // NOI18N
if (s.equalsIgnoreCase("ops")) // NOI18N
flags |= Term.DEBUG_OPS;
else if (s.toLowerCase().equals("keys")) // NOI18N
else if (s.equalsIgnoreCase("keys")) // NOI18N
flags |= Term.DEBUG_KEYS;
else if (s.toLowerCase().equals("input")) // NOI18N
else if (s.equalsIgnoreCase("input")) // NOI18N
flags |= Term.DEBUG_INPUT;
else if (s.toLowerCase().equals("output")) // NOI18N
else if (s.equalsIgnoreCase("output")) // NOI18N
flags |= Term.DEBUG_OUTPUT;
else if (s.toLowerCase().equals("wrap")) // NOI18N
else if (s.equalsIgnoreCase("wrap")) // NOI18N
flags |= Term.DEBUG_WRAP;
else if (s.toLowerCase().equals("margins")) // NOI18N
else if (s.equalsIgnoreCase("margins")) // NOI18N
flags |= Term.DEBUG_MARGINS;
else if (s.toLowerCase().equals("sequences")) // NOI18N
else if (s.equalsIgnoreCase("sequences")) // NOI18N
term.setSequenceLogging(true);
else
;
Expand Down
6 changes: 3 additions & 3 deletions ide/xml.text.obsolete90/src/org/netbeans/modules/xml/text/syntax/XMLSyntaxSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ public int[] findMatch(int offset, boolean simpleSearch)
String tag = token.getImage().substring(2).trim().toLowerCase();
while ( token != null){
if (token.getTokenID() == XMLTokenIDs.TAG && !">".equals(token.getImage())) {
if (token.getImage().substring(1).trim().toLowerCase().equals(tag)
if (token.getImage().substring(1).trim().equalsIgnoreCase(tag)
&& !isSingletonTag(token)) {
//it's an open tag
if (poss == 0){
Expand Down Expand Up @@ -911,7 +911,7 @@ public int[] findMatch(int offset, boolean simpleSearch)
String tag = token.getImage().substring(1).toLowerCase();
while ( token != null){
if (token.getTokenID() == XMLTokenIDs.TAG && !">".equals(token.getImage())) {
if (token.getImage().substring(2).trim().toLowerCase().equals(tag)) {
if (token.getImage().substring(2).trim().equalsIgnoreCase(tag)) {
//it's a close tag
if (poss == 0) {
//get offset of previous token: < or </
Expand All @@ -922,7 +922,7 @@ public int[] findMatch(int offset, boolean simpleSearch)
} else
poss--;
} else{
if (token.getImage().substring(1).toLowerCase().equals(tag)
if (token.getImage().substring(1).equalsIgnoreCase(tag)
&& !isSingletonTag(token))
poss++;
}
Expand Down
2 changes: 1 addition & 1 deletion java/debugger.jpda.js/src/org/netbeans/modules/debugger/jpda/js/source/Source.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public static Source getSource(JPDADebugger debugger, JPDAClassType classType, O
name = name.substring(1, name.length() - 1);
}
int nl = name.length();
if (nl < 4 || !name.substring(nl - 3, nl).toLowerCase().equals(".js")) {
if (nl < 4 || !name.substring(nl - 3, nl).equalsIgnoreCase(".js")) {
name = name + ".js";
}
// Check whether the file happens to exist
Expand Down
2 changes: 1 addition & 1 deletion java/form/src/org/netbeans/modules/form/editors/PrimitiveTypeArrayEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ private Object text2Arr(String text) throws ParseException {
String[] parts;
String trimText = text.trim();

if ((trimText.length() == 0) || trimText.toLowerCase().equals(NULL_STR)) {
if ((trimText.length() == 0) || trimText.equalsIgnoreCase(NULL_STR)) {
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion java/java.hints/src/org/netbeans/modules/java/hints/WrongPackageSuggestion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ else if (tree.getTypeDecls().isEmpty()){

String packageLocation = cp.getResourceName(info.getFileObject().getParent(), '.', false);

if ((isCaseSensitive() && packageName.equals(packageLocation)) || (!isCaseSensitive() && packageName.toLowerCase().equals(packageLocation.toLowerCase()))) {
if ((isCaseSensitive() && packageName.equals(packageLocation)) || (!isCaseSensitive() && packageName.equalsIgnoreCase(packageLocation))) {
return null;
}

Expand Down
Loading