Fix errors from java multi-file source launcher#6832
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Dec 12, 2023
Merged
Fix errors from java multi-file source launcher#6832matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing merged 1 commit intoapache:masterfrom
Conversation
Contributor
matthiasblaesing
commented
Dec 11, 2023
matthiasblaesing
commented
- Guard against problem writing VM attributes (check if filesystem is writeable and reduce log severity to info=
- Check FileObject for validity before trying to read from it
- Guard against problem writing VM attributes (check if filesystem is writeable and reduce log severity to info= - Check FileObject for validity before trying to read from it
matthiasblaesing
added
the
Java
lahodaj
approved these changes
Dec 11, 2023
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
Author
|
@lahodaj thanks for the quick review. github actions is also happy, so lets get this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.