Not registering the LSP's SingleFileOptionsQueryImpl in java.lsp.server, but only in nbcode#6854
Merged
lahodaj merged 1 commit intoapache:masterfrom Jan 5, 2024
Merged
Conversation
…er, but only in nbcode
mbien
added
Java
Member
|
thanks a lot for fixing this. I tested the dev build and can confirm that |
sdedic
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted here:
#6329 (comment)
the compiler options set a VM Options for a source-file launcher are not working in the NetBeans GUI. The reason is that the provider from
java.lsp.serveroverrides the default provider.This patch moves the registration into nbcode, which, I believe, is what has been done in similar cases.
Also, in
TextDocumentServiceImpl.resolveCodeAction, the data may benull, I believe (like for the "Enable Preview" action), adding a null check.