Conversation
mbien
added
Code cleanup
Member
Author
|
all tests green without restarts, must be a good omen |
Contributor
|
From a very quick look this seems sane. Indeed we might consider also dropping spring framework 3+4 and updating spring framework 5 libraries to latest |
Member
Author
|
@matthiasblaesing thanks for taking a look. Will leave this as draft at least until NB 21 is released, since this could cause unnecessary sync conflicts.
agreed, We should drop everything which is EOL if possible, starting with the oldest/easiest to remove first. EOL spring will also show up on CVE scanners etc. |
mbien
removed
the
ci:dev-build
last struts 1 release was 14 years ago.
Member
Author
|
same here, rebasing to latest for a fresh run. |
matthiasblaesing
approved these changes
Feb 11, 2024
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me.
Member
Author
|
thanks for the review again @matthiasblaesing -> merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last struts 1 release was 14 years ago, time for cleanup.
this removes the
enterprise/web.strutsmodule, which is a lib wrapper and provided a few wizards, integrated the wrapped struts libs intotools -> librariesand offered struts 1 as J2EE framework to other modules.ran a quick manual test to see that the old ant project wizard is still working (
new project -> java with ant -> java web -> web application).closes #6969
closes #6686