Retire EOL Spring 3, 4 and update Spring 5 lib wrapper to 5.3.31.#6994
Merged
mbien merged 1 commit intoapache:masterfrom Feb 10, 2024
Merged
Retire EOL Spring 3, 4 and update Spring 5 lib wrapper to 5.3.31.#6994mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
mbien
added
Code cleanup
mbien
force-pushed
the
retire-eol-spring-libs
branch
from
f07d6b3 to
b2a4e70
Compare
mbien
added
Java
mbien
force-pushed
the
retire-eol-spring-libs
branch
from
b2a4e70 to
80f6dcf
Compare
matthiasblaesing
approved these changes
Jan 27, 2024
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
- removed spring 3 and 4 - updated spring 5 from 5.2.9 to 5.3.31 - minor code cleanup
mbien
removed
the
ci:dev-build
mbien
force-pushed
the
retire-eol-spring-libs
branch
from
80f6dcf to
aa03d94
Compare
Member
Author
|
rebased to latest, planning to merge this soon assuming the new updated CI workflow is green too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the EOL lib removal quest continues
note: I did not add/remove any jars in the hope that not much changed between 5.2 and 5.3.
manual test:
tools -> librariesshould only have spring 5.x libs