Integrate NB Favorites with the FileChooser shortcuts panel by mbien · Pull Request #7164 · apache/netbeans

mbien · 2024-03-16T07:51:08Z

Link the Favorites view with FlatLaf's FileChooser shortcuts panel.

the first commit is code cleanup
second commit contains minor updates to the path completion functionality (who knew that the NB directory chooser had auto completion?)
third commit is the main change which provides the favorites shortcuts list

screenshots:
JDK's FileChooser with favorites:

NB's custom DirectoryChooser displaying lots of favorites in a JScrollPane.

can be enabled via FlatLaf options (last checkbox):

mbien · 2024-03-16T07:56:19Z

ide/o.n.swing.dirchooser/src/org/netbeans/swing/dirchooser/DirectoryChooserUI.java

+        if (useNBShortcutsPanel()) {
+            FlatShortcutsPanel shortcuts = new FlatShortcutsPanel(fileChooser);
+            JScrollPane sp = new JScrollPane(shortcuts, JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED, JScrollPane.HORIZONTAL_SCROLLBAR_NEVER);
+            sp.setPreferredSize(new Dimension(100, 300));
+            return sp;
+        }


@DevCharly do you think it would make sense for FlatLaf to wrap the FlatShortcutsPanel in a JScrollPane like here? (see second screenshot)

NB uses two file choosers, one is customized (DirectoryChooserUI) and used for opening projects etc, the other one is the standard JDK file chooser. Now when the shortcuts panel has lots of items the standard JDK file chooser will get very tall.

filed JFormDesigner/FlatLaf#828

neilcsmith-net

Great idea! But I'd like to see it done without additional dependencies or look-and-feel specific checks being added. UIManager keys should be the way to centralise this in my opinion.

ide/o.n.swing.dirchooser/nbproject/project.xml

ide/o.n.swing.dirchooser/src/org/netbeans/swing/dirchooser/DirectoryChooserUI.java

neilcsmith-net · 2024-03-18T10:04:58Z

ide/o.n.swing.dirchooser/src/org/netbeans/swing/dirchooser/Module.java

+            }
+            return list.toArray(File[]::new);
+        };
+        UIManager.put("FileChooser.shortcuts.filesFunction", fun);


Adopt this as a provided NetBeans key and provide from the Favorites module directly?

Could also consider if Favorites should prepopulate favorites from the shell folders on Windows, and then allow all OS to use Favorites to customise links in file chooser panels for consistency?

what is a NetBeans Key?

I just meant a UI key that's added and documented in https://github.com/apache/netbeans/blob/master/platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/LFCustoms.java Although it would be kind of operating in reverse to most UI keys, in the sense that it's set outside and read by the LAF.

Could also consider if Favorites should prepopulate favorites from the shell folders on Windows, and then allow all OS to use Favorites to customise links in file chooser panels for consistency?

the way it works right now on windows is that the NB favorites are appended to the windows specific shortcuts:

~~the win ShellFolder reflection code is essentially not needed in dir file folder if FlatLaf is used since the shortcuts panel is doing this already.~~ actually: I believe this isn't quite correct, some of the code is probably still active.

mbien · 2024-03-24T23:21:11Z

this can be now enabled via FlatLaf options (no restart required), see added screenshot

ide/o.n.swing.dirchooser/nbproject/project.properties

mbien · 2024-04-02T21:28:08Z

appended (experimental) to the checkbox text and rebased PR to latest of master

neilcsmith-net

Changes look good to me. I guess you could remove the dependency changes entirely by using String literals, but pros and cons to that.

mbien · 2024-04-04T12:08:37Z

platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/LFCustoms.java

+    /**
+     * FileChooser
+     */
+    public static final String FILECHOOSER_SHORTCUTS_FILESFUNCTION = "FileChooser.shortcuts.filesFunction";
+    public static final String FILECHOOSER_SHORTCUTS_PANEL_FACTORY = "FileChooser.shortcuts.panel.factory";
+    public static final String FILECHOOSER_FAVORITES_ENABLED = "FileChooser.favorites.enabled";


@neilcsmith-net btw the _FILESFUNCTION key value (FileChooser.shortcuts.filesFunction) is taken right from FlatLaf. Not sure if this is elegant or a horrible idea. I just thought that mapping one key to another would create more problems than its worth the trouble since it can get out of sync easily.

Yes, I knew that when I suggested adopting it. Don't see a reason to use something different and have the problems of syncing. Whether it's elegant or horrible ... 🤷

- added ctrl+space to the trigger list - increased popup size from 4 to 6 lines - filter out hidden files

- file chooser shortcuts panel can optionally append the tree roots of the favorites view - can be toggled in the FlatLaf options This requires to open com.formdev.flatlaf.ui as friend dependency, which is as mentioned in project.properties not part of the stable API.

mbien · 2024-04-04T15:30:13Z

fixed a typo, going to merge once green again. Thanks for reviewing.

mbien added Look and Feel UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 16, 2024

mbien requested review from DevCharly, eirikbakke and neilcsmith-net March 16, 2024 07:51

mbien commented Mar 16, 2024

View reviewed changes

neilcsmith-net requested changes Mar 18, 2024

View reviewed changes

mbien force-pushed the filechooser-shortcuts-panel branch 2 times, most recently from d9e8dff to 99e6f7a Compare March 24, 2024 23:14

mbien force-pushed the filechooser-shortcuts-panel branch from 99e6f7a to 71d4d2a Compare March 25, 2024 12:46

mbien marked this pull request as ready for review March 25, 2024 12:46

mbien added this to the NB22 milestone Mar 25, 2024

mbien added the Platform [ci] enable platform tests (platform/*) label Mar 25, 2024

apache locked and limited conversation to collaborators Mar 25, 2024

apache unlocked this conversation Mar 25, 2024

mbien force-pushed the filechooser-shortcuts-panel branch from 71d4d2a to 80d65f9 Compare March 25, 2024 15:12

mbien commented Mar 25, 2024

View reviewed changes

ide/o.n.swing.dirchooser/nbproject/project.properties Show resolved Hide resolved

mbien requested a review from neilcsmith-net March 27, 2024 12:54

mbien mentioned this pull request Mar 27, 2024

Wrap FileChooser's shortcuts panel in vertical scroll pane JFormDesigner/FlatLaf#828

Closed

mbien force-pushed the filechooser-shortcuts-panel branch from 80d65f9 to 10b3c5b Compare April 2, 2024 21:28

neilcsmith-net approved these changes Apr 4, 2024

View reviewed changes

mbien commented Apr 4, 2024

View reviewed changes

mbien added 3 commits April 4, 2024 17:26

dirchooser cleanup: deprecations, workarounds and simplifications

94301c0

DirectoryChooser completion tweaks

c2130a1

- added ctrl+space to the trigger list - increased popup size from 4 to 6 lines - filter out hidden files

mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Apr 4, 2024

mbien force-pushed the filechooser-shortcuts-panel branch from 10b3c5b to ce3cca2 Compare April 4, 2024 15:29

mbien merged commit 18f73f7 into apache:master Apr 4, 2024

mbien mentioned this pull request Jul 16, 2024

Update FlatLaf from 3.3 to 3.5 #7565

Merged

Conversation

mbien commented Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbien Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbien Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

neilcsmith-net left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

neilcsmith-net Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

mbien Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

neilcsmith-net Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbien Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbien commented Mar 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mbien commented Apr 2, 2024

Uh oh!

neilcsmith-net left a comment

Choose a reason for hiding this comment

Uh oh!

mbien Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neilcsmith-net Apr 4, 2024

Choose a reason for hiding this comment

Uh oh!

mbien commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mbien commented Mar 16, 2024 •

edited

Loading

mbien Mar 16, 2024 •

edited

Loading

neilcsmith-net Mar 18, 2024 •

edited

Loading

mbien Mar 19, 2024 •

edited

Loading

mbien commented Mar 24, 2024 •

edited

Loading

mbien Apr 4, 2024 •

edited

Loading