Skip to content

MavenVersionSettings: Stick to maven 3 plugins for now#7574

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:stick-to-mvn3-plugins
Jul 14, 2024
Merged

MavenVersionSettings: Stick to maven 3 plugins for now#7574
mbien merged 1 commit intoapache:masterfrom
mbien:stick-to-mvn3-plugins

Conversation

@mbien
Copy link
Member

@mbien mbien commented Jul 13, 2024

  • NB wizards and similar features should not blindly upgrade to mvn4 core plugins
  • also bumps version fallback of surefire/failsafe to 3.3.1

fixes #7571

example how to test:

  • your local repo must contain maven-compiler-plugin v 4.0.0-beta-1
  • create maven project, make sure nb scanned your local repo
  • open project properties -> compiler, enable -Xlint, this will insert the compiler plugin into the pom
  • version should not exceed 3.x

 - NB wizards and similar features should not blindly upgrade to mvn4
   core plugins
 - also bumps version fallback of surefire/failsafe to 3.3.1
@mbien mbien added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 13, 2024
@mbien mbien added this to the NB23 milestone Jul 13, 2024
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach makes sense to me and good seems trivially correct. Thanks.

@mbien mbien merged commit 6d5b4c8 into apache:master Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal utilities for maven plugin core dependency updates should stick to 3.x version for now

2 participants