Skip to content

Update ASM from 9.7 to 9.7.1#7886

Merged
mbien merged 1 commit intoapache:masterfrom
mbien:asm971
Oct 20, 2024
Merged

Update ASM from 9.7 to 9.7.1#7886
mbien merged 1 commit intoapache:masterfrom
mbien:asm971

Conversation

@mbien
Copy link
Member

@mbien mbien commented Oct 18, 2024

JDK 24 support + bugfixes (https://asm.ow2.io/versions.html)

last update to compare with 10b9d58 + 045f99c

@mbien mbien added Upgrade Library Library (Dependency) Upgrade ci:all-tests [ci] enable all tests labels Oct 18, 2024
@mbien mbien added this to the NB24 milestone Oct 18, 2024
@mbien
Copy link
Member Author

mbien commented Oct 18, 2024

ci:all-tests [ci] enable all tests label (which also builds all tests) found a problem

 [nb-javac] /home/runner/work/netbeans/netbeans/java/java.file.launcher/test/unit/src/org/netbeans/modules/java/file/launcher/actions/JavaFileTest.java:60: error: method invokeActionHelper in class SingleJavaSourceRunActionProvider cannot be applied to given types;
 [nb-javac]         LaunchProcess process = runActionProvider.invokeActionHelper(null, "run.single", javaFO, ExplicitProcessParameters.empty());
 [nb-javac]                                                  ^
 [nb-javac]   required: String,FileObject,ExplicitProcessParameters
 [nb-javac]   found:    <null>,String,FileObject,ExplicitProcessParameters
 [nb-javac]   reason: actual and formal argument lists differ in length

test wasn't updated in #7776, going to fix this quickly
edit: see #7887

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only build + eyeballed this, but looks sane to me. Changelog does not indicate incompatible changes (neither API, nor classlevel), so I would expect this to work.

@apache apache locked and limited conversation to collaborators Oct 20, 2024
@apache apache unlocked this conversation Oct 20, 2024
@mbien mbien merged commit 886c8cc into apache:master Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants