Action for running tests in parallel by petrovic-d · Pull Request #7979 · apache/netbeans

petrovic-d · 2024-11-22T15:04:21Z

New action for running tests in parallel. It can be invoked via command: nbls.run.test.parallel
Command support specifying modules for which tests will be ran in parallel. It's up to client to pass the module list, so by default it will run without passed modules.
To test it with module list, it needs to be modified like this:
in java/java.lsp.server/vscode/src/extension.ts file
modify line 835 to:
testAdapter?.run(new vscode.TestRunRequest(), new vscode.CancellationTokenSource().token, true, ["module1", "module2"]);

extide/gradle/src/org/netbeans/modules/gradle/ActionProviderImpl.java

ide/extexecution.base/src/org/netbeans/api/extexecution/base/ExplicitProcessParameters.java

...a.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java

java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java

java/maven/src/org/netbeans/modules/maven/execute/AbstractOutputHandler.java

java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java

java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineOptions.java

java/maven/src/org/netbeans/modules/maven/execute/cmd/ExecMojo.java

java/maven/src/org/netbeans/modules/maven/execute/model/NetbeansActionMapping.java

ide/projectapi/src/org/netbeans/spi/project/ContainedProjectFilter.java

java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/TestProgressHandler.java

java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/ModuleInfo.java

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/TestProgressHandler.java

.../java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/WorkspaceServiceImpl.java

sdedic · 2024-12-04T10:12:28Z

java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java

        "javadoc", //NOI18N
        COMMAND_TEST,
        COMMAND_TEST_SINGLE,
+        COMMAND_TEST_PARALLEL,


bump dependency version on project.api

java/maven/src/org/netbeans/modules/maven/api/execute/RunConfig.java

java/maven/nbproject/org-netbeans-modules-maven.sig

Issue addressed

sdedic · 2024-12-05T05:49:36Z

@neilcsmith-net please advise how to fix build failure https://github.com/apache/netbeans/actions/runs/12162766052/job/33936238338?pr=7979 related to signature check. There's a (formally) incompatible change on friend-only API.

mbien

was this tested with mvnd? mvnd builds multithreaded by default, mvn builds singlethreaded by default (without extra flags).

java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java

neilcsmith-net · 2024-12-05T09:55:07Z

@sdedic sorry, I'd missed that the addition was incompatible. Am not involved with releases at the moment, and only commented after a glance at this to try and save @ebarboni some headaches post NB24.

If this has to go in as is, then either wait for the API sigs to merge in a week or so and rebase, manually patch the 3 required lines into the sig file (which should pass then?), or merge and be prepared to help Eric with the API signature integration post release.

OTOH, either the test is relevant or not? Add the methods as default on the interface, as you did in the last change to that file to not require changes to pass tests? Or lets just stop having sigtests for friend APIs as they're irrelevant - the build will pick up internal breakage, and we don't support external usage.

Our process for handling sig tests for releases could do with a review anyway. I have some ideas how to improve that, but we have the one we have for now.

petrovic-d · 2024-12-05T12:33:36Z

@mbien I tried with mvnd and it ran all tests successfully with this action

petrovic-d · 2024-12-12T14:47:57Z

@ebarboni When can we expect sigs to be generated for the release, since this PR should (probably) introduce changes to .sig?

neilcsmith-net · 2024-12-12T14:50:48Z

@petrovic-d follow #8034

ebarboni · 2024-12-12T15:21:25Z

sig pr merged

java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/TestProgressHandler.java

java/java.source.base/src/org/netbeans/api/java/source/SourceUtils.java

java/maven/src/org/netbeans/modules/maven/api/execute/RunConfig.java

ide/projectapi/src/org/netbeans/spi/project/NestedClass.java

ide/projectapi/src/org/netbeans/spi/project/SingleMethod.java

sdedic · 2024-12-18T08:34:30Z

...a.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java

+
+    static ContainedProjectFilter getProjectFilter(Project prj, Map<String, Object> launchArguments) {
+        List<String> projectsArg = argsToStringList(launchArguments.get("projects"));
+        List<Project> projects = ProjectUtils.getContainedProjects(prj, false).stream()


Note: this does not allow to specify projects nested more levels in the project's hierarchy. Not a bug, and can be enhanced later in a compatible way.

.../java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/WorkspaceServiceImpl.java

java/java.lsp.server/vscode/src/testAdapter.ts

lahodaj · 2024-12-18T14:12:02Z

ide/projectapi/src/org/netbeans/spi/project/NestedClass.java

+ * 
+ * @since 1.99
+ */
+public final class NestedClass {


Not really a request to change anything, just an observation: this whole angle around NestedClass seems mostly orthogonal to the run tests in parallel feature, and could probably have been a separate PR.

sdedic

Looks good, thanks!

sdedic · 2024-12-18T18:23:39Z

@petrovic-d assuming rebase & squash

matyasberry · 2025-03-10T08:36:18Z

Hi, any chance of reusing these changes to also support what #3995 was intended to do?

petrovic-d · 2025-03-17T09:18:37Z

Hi, any chance of reusing these changes to also support what #3995 was intended to do?

@matyasberry Hi, this PR should also add support for nested classes -> see this

apache locked and limited conversation to collaborators Nov 22, 2024

apache unlocked this conversation Nov 22, 2024

MartinBalin requested review from dbalek, lahodaj, lkishalmi and sdedic and removed request for lahodaj November 25, 2024 16:33

sdedic requested changes Nov 30, 2024

View reviewed changes

sdedic assigned petrovic-d Nov 30, 2024

sdedic added API Change [ci] enable extra API related tests kind:feature A feature request labels Nov 30, 2024

petrovic-d requested a review from sdedic December 3, 2024 07:22

sdedic reviewed Dec 4, 2024

View reviewed changes

petrovic-d force-pushed the action-for-running-tests-in-parallel branch from d717d00 to a8c4d23 Compare December 4, 2024 14:42

neilcsmith-net previously requested changes Dec 4, 2024

View reviewed changes

java/maven/nbproject/org-netbeans-modules-maven.sig Show resolved Hide resolved

petrovic-d force-pushed the action-for-running-tests-in-parallel branch from c3ae922 to 54b4326 Compare December 4, 2024 15:18

petrovic-d requested a review from neilcsmith-net December 4, 2024 15:18

neilcsmith-net removed their request for review December 4, 2024 17:09

sdedic added API Change [ci] enable extra API related tests and removed API Change [ci] enable extra API related tests labels Dec 5, 2024

mbien reviewed Dec 5, 2024

View reviewed changes

java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java Outdated Show resolved Hide resolved

petrovic-d force-pushed the action-for-running-tests-in-parallel branch from cb073da to dfa178e Compare December 10, 2024 08:16

petrovic-d force-pushed the action-for-running-tests-in-parallel branch from 55cabe8 to 5d62a2f Compare December 13, 2024 08:44

sdedic added this to the NB25 milestone Dec 17, 2024

sdedic reviewed Dec 18, 2024

View reviewed changes

lahodaj reviewed Dec 18, 2024

View reviewed changes

sdedic approved these changes Dec 18, 2024

View reviewed changes

Action for running tests in parallel

40bae1a

petrovic-d force-pushed the action-for-running-tests-in-parallel branch from 8143039 to 40bae1a Compare December 18, 2024 17:22

sdedic merged commit 9d5bc1e into apache:master Dec 19, 2024
38 checks passed

sdedic mentioned this pull request Jan 20, 2025

Change parameter order for runDebug, compat with NBLS codelenses. #8173

Merged

This was referenced May 26, 2025

mvnd does not signal test run completion do NetBeans IDE apache/maven-mvnd#1333

Closed

Fix mvnd test session regression #8539

Merged

matthiasblaesing mentioned this pull request Jun 1, 2025

Support JUnit5 nested test classes #3995

Closed

Conversation

petrovic-d commented Nov 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sdedic Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sdedic commented Dec 5, 2024

Uh oh!

mbien left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neilcsmith-net commented Dec 5, 2024

Uh oh!

petrovic-d commented Dec 5, 2024

Uh oh!

petrovic-d commented Dec 12, 2024

Uh oh!

neilcsmith-net commented Dec 12, 2024

Uh oh!

ebarboni commented Dec 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sdedic Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lahodaj Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

sdedic left a comment

Choose a reason for hiding this comment

Uh oh!

sdedic commented Dec 18, 2024

Uh oh!

Uh oh!

matyasberry commented Mar 10, 2025

Uh oh!

petrovic-d commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants