Skip to content

libs.fabric8: Prevent generation of signature files and fix description#8162

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:disable-sigfiles-fabric8
Jan 17, 2025
Merged

libs.fabric8: Prevent generation of signature files and fix description#8162
matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing:disable-sigfiles-fabric8

Conversation

@matthiasblaesing
Copy link
Contributor

No description provided.

@matthiasblaesing matthiasblaesing added the enterprise [ci] enable enterprise job label Jan 16, 2025
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Jan 16, 2025
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

Copy link
Member

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it.

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

Given your comment about sigtests and version, possibly consider adding the library version as the module implementation version like we do elsewhere too?

@matthiasblaesing
Copy link
Contributor Author

@jhorvath @neilcsmith-net @mbien thank you all for review!

@neilcsmith-net using the library version as module version is indeed an option, but it will still need active checking from the updater. The spec version and the major module version are not linked. Nothing is stopping you from going from org.netbeans.libs.fabric8/1 with spec version 1.11 to org.netbeans.libs.fabric8/1 with spec version 2.0, while you most probably wanted to go to org.netbeans.libs.fabric8/2 with spec version 2.0. Only the second variant indicates an incompatible update as in "the IDE prevents linking" (at least to my understanding).

I would expect such a high profile module to follow semantic versioning, but that would need checking. Another think is preventing bump of spec version in release, else the versions will drift again.

At this point in time I think it is better to focus on the freeze.

@matthiasblaesing matthiasblaesing merged commit 695671f into apache:master Jan 17, 2025
31 checks passed
@neilcsmith-net
Copy link
Member

neilcsmith-net commented Jan 17, 2025

@matthiasblaesing absolutely, doesn't provide any additional protection, just a little extra info.

@jhorvath if you update these libs in future, please consider mapping the upstream version to implementation version, as with a few other recent third party additions.

@mbien
Copy link
Member

mbien commented Jan 17, 2025

one thing we should do at some point is to switch to jdk equivalents
https://github.com/matthiasblaesing/netbeans/blob/e09743956d580fa65411594acb197b02c3eba802/enterprise/libs.fabric8/external/binaries-list#L41-L45
kubernetes-httpclient-jdk is available for example. I think this would be even possible before freeze as long its manually tested.

this was also mentioned under the original PR

@matthiasblaesing matthiasblaesing deleted the disable-sigfiles-fabric8 branch March 5, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise [ci] enable enterprise job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments