libs.fabric8: Prevent generation of signature files and fix description#8162
Conversation
jhorvath
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing it.
neilcsmith-net
left a comment
There was a problem hiding this comment.
Thanks for fixing.
Given your comment about sigtests and version, possibly consider adding the library version as the module implementation version like we do elsewhere too?
|
@jhorvath @neilcsmith-net @mbien thank you all for review! @neilcsmith-net using the library version as module version is indeed an option, but it will still need active checking from the updater. The spec version and the major module version are not linked. Nothing is stopping you from going from I would expect such a high profile module to follow semantic versioning, but that would need checking. Another think is preventing bump of spec version in release, else the versions will drift again. At this point in time I think it is better to focus on the freeze. |
|
@matthiasblaesing absolutely, doesn't provide any additional protection, just a little extra info. @jhorvath if you update these libs in future, please consider mapping the upstream version to implementation version, as with a few other recent third party additions. |
|
one thing we should do at some point is to switch to jdk equivalents this was also mentioned under the original PR |
No description provided.