Fix move/copy/rename/etc for standalone java files.#8679
Merged
ebarboni merged 1 commit intoapache:deliveryfrom Jul 28, 2025
Merged
Fix move/copy/rename/etc for standalone java files.#8679ebarboni merged 1 commit intoapache:deliveryfrom
ebarboni merged 1 commit intoapache:deliveryfrom
Conversation
- disable some refactoring actions for standalone source files, since they throw exceptions without having project context - this will delegate to generic file actions Co-authored-by: Michael Bien <mbien42@gmail.com>
mbien
added
Java
neilcsmith-net
approved these changes
Jul 28, 2025
Member
There was a problem hiding this comment.
Quickly tested your branch before you opened the PR. Seems to re-enable key file actions, including with default settings. Some refactoring operations working with indexing.
Agree with merge for rc2. However, refactoring support for source launcher files, particularly as not enabled by default, is quite niche compared to basic file operations on them. Any further sign of regressions from NB26, and we should revert the lot in rc3.
Thanks for adding the TODO line! We really need to fix the dependency relationships here.
lahodaj
approved these changes
Jul 28, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative would be to revert #8442 instead of attempting this selective approach
tested by dragging java files around which triggers the move refactoring, renamed some etc. This should work with "source file launcher indexing" enabled and disabled (file properties). With indexing disabled it should handle files without doing any code refactoring (like in NB 26).
Not all refactorings work but those which failed, failed gracefully, e.g window telling that the file is outside a project.
targets delivery