-
Notifications
You must be signed in to change notification settings - Fork 917
Add hint to resolve "switch does not cover all input values" javac errors #8860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
159 changes: 159 additions & 0 deletions
159
java/java.hints/src/org/netbeans/modules/java/hints/errors/AddDefaultCase.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.netbeans.modules.java.hints.errors; | ||
|
|
||
| import com.sun.source.tree.BreakTree; | ||
| import com.sun.source.tree.CaseTree; | ||
| import com.sun.source.tree.CaseTree.CaseKind; | ||
| import com.sun.source.tree.ExpressionTree; | ||
| import com.sun.source.tree.ParenthesizedTree; | ||
| import com.sun.source.tree.StatementTree; | ||
| import com.sun.source.tree.SwitchExpressionTree; | ||
| import com.sun.source.tree.SwitchTree; | ||
| import com.sun.source.tree.Tree; | ||
| import com.sun.source.util.SourcePositions; | ||
| import com.sun.source.util.TreePath; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import org.netbeans.api.java.source.CompilationInfo; | ||
| import org.netbeans.api.java.source.TreeMaker; | ||
| import org.netbeans.api.java.source.WorkingCopy; | ||
| import org.netbeans.modules.java.hints.spi.ErrorRule; | ||
| import org.netbeans.spi.editor.hints.Fix; | ||
| import org.netbeans.spi.java.hints.JavaFix; | ||
| import org.openide.util.NbBundle; | ||
|
|
||
| /** | ||
| * Resolves javac error by adding a missing default case to a switch. | ||
| * | ||
| * @author SANDEEMI | ||
| */ | ||
| @NbBundle.Messages("FIX_Add_Default_Case=Add Default Case") | ||
| public class AddDefaultCase implements ErrorRule<Void> { | ||
|
|
||
| private static final Set<String> CODES = Set.of( | ||
| "compiler.err.not.exhaustive", | ||
| "compiler.err.not.exhaustive.statement" | ||
| ); | ||
|
|
||
| private static final String THROW_ISE = "throw new IllegalStateException(\"Unexpected value: \" + %1$s);"; | ||
|
|
||
| @Override | ||
| public Set<String> getCodes() { | ||
| return CODES; | ||
| } | ||
|
|
||
| @Override | ||
| public List<Fix> run(CompilationInfo info, String diagnosticKey, int offset, TreePath treePath, Data<Void> data) { | ||
| return List.of(new AddDefaultCaseFix(info, treePath).toEditorFix()); | ||
| } | ||
|
|
||
| @Override | ||
| public String getId() { | ||
| return AddDefaultCase.class.getName(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getDisplayName() { | ||
| return Bundle.FIX_Add_Default_Case(); | ||
| } | ||
|
|
||
| @Override | ||
| public void cancel() { | ||
|
|
||
| } | ||
|
|
||
| private static final class AddDefaultCaseFix extends JavaFix { | ||
|
|
||
| public AddDefaultCaseFix(CompilationInfo info, TreePath path) { | ||
| super(info, path); | ||
| } | ||
|
|
||
| @Override | ||
| protected String getText() { | ||
| return Bundle.FIX_Add_Default_Case(); | ||
| } | ||
|
|
||
| @Override | ||
| protected void performRewrite(TransformationContext ctx) throws Exception { | ||
| WorkingCopy wc = ctx.getWorkingCopy(); | ||
| TreeMaker make = wc.getTreeMaker(); | ||
| TreePath path = ctx.getPath(); | ||
|
|
||
| switch (path.getLeaf().getKind()) { | ||
| case SWITCH_EXPRESSION -> { | ||
| SwitchExpressionTree expTree = (SwitchExpressionTree) path.getLeaf(); | ||
| List<? extends CaseTree> cases = expTree.getCases(); | ||
| if (cases.isEmpty()) { | ||
| return; | ||
| } | ||
| ParenthesizedTree expression = (ParenthesizedTree) expTree.getExpression(); | ||
|
|
||
| String text = THROW_ISE.formatted(expression.toString()); | ||
| StatementTree parseStatement = wc.getTreeUtilities().parseStatement(text, new SourcePositions[1]); | ||
| CaseTree caseSwitchPatterns; | ||
| if (cases.get(0).getCaseKind() == CaseKind.RULE) { | ||
| caseSwitchPatterns = make.CasePatterns(List.of(), parseStatement); | ||
| } else { | ||
| caseSwitchPatterns = make.CasePatterns(List.of(), List.of(parseStatement)); | ||
| } | ||
|
|
||
| List<CaseTree> newCases = new ArrayList<>(cases.size() + 1); | ||
| newCases.addAll(cases); | ||
| newCases.add(caseSwitchPatterns); | ||
| Tree switchExpression = make.SwitchExpression(expression, newCases); | ||
| wc.rewrite(expTree, switchExpression); | ||
| } | ||
| case SWITCH -> { | ||
| SwitchTree switchTree = (SwitchTree) path.getLeaf(); | ||
| List<? extends CaseTree> cases = switchTree.getCases(); | ||
| if (cases.isEmpty()) { | ||
| return; | ||
| } | ||
| ExpressionTree expression = ((ParenthesizedTree) switchTree.getExpression()).getExpression(); | ||
|
|
||
| String text = THROW_ISE.formatted(expression.toString()); | ||
| StatementTree parseStatement = wc.getTreeUtilities().parseStatement(text, new SourcePositions[1]); | ||
| CaseTree caseSwitchPatterns; | ||
| if (cases.get(0).getCaseKind() == CaseKind.RULE) { | ||
| caseSwitchPatterns = make.CasePatterns(List.of(), parseStatement); | ||
| } else { | ||
| handleLastCase(cases.get(cases.size() - 1), wc, make); | ||
| caseSwitchPatterns = make.CasePatterns(List.of(), List.of(parseStatement)); | ||
| } | ||
|
|
||
| SwitchTree insertSwitchCase = make.addSwitchCase(switchTree, caseSwitchPatterns); | ||
| wc.rewrite(switchTree, insertSwitchCase); | ||
| } | ||
| default -> throw new UnsupportedOperationException(path.getLeaf().getKind() + " not implemented"); | ||
| } | ||
| } | ||
|
|
||
| private static void handleLastCase(CaseTree lastCase, WorkingCopy wc, TreeMaker make) { | ||
| List<? extends StatementTree> statements = lastCase.getStatements(); | ||
| if (statements.isEmpty() || !(statements.get(statements.size() - 1) instanceof BreakTree)) { | ||
| List<StatementTree> expanded = new ArrayList<>(statements.size() + 1); | ||
| expanded.addAll(statements); | ||
| expanded.add(make.Break(null)); | ||
| wc.rewrite(lastCase, make.CasePatterns(lastCase.getLabels(), expanded)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.