Use DEFAULT_TASK_STACKSIZE #145
Conversation
|
Nice patch! |
|
using more memory might or might not be safe for small systems. |
Yes, but since: |
For now, I left the following instances because it isn't
clear to me why they are using the different values.
Maybe they need one-by-one inspection.
examples/igmp/Makefile:STACKSIZE = 1024
examples/powerled/Makefile:STACKSIZE = 1024
examples/powermonitor/Makefile:STACKSIZE = 768
examples/relays/Makefile:STACKSIZE = 512
examples/smps/Makefile:STACKSIZE = 1024
graphics/screenshot/Makefile:STACKSIZE = 4096
system/flash_eraseall/Makefile:STACKSIZE = 1024
testing/cxxtest/Makefile:STACKSIZE = 4096
testing/smart_test/Makefile:STACKSIZE = 4096
This commit changes only ones with the default 2048 and leaves the others. E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024. I guess those need to be inspected one-by-one.
These had the larger default for the sim.
It's no longer necessary as DEFAULT_TASK_STACKSIZE
can have different default for each arch.
See also:
commit b1d44a8
Where the hardcoded values are less than 2048. Using a bit more memory for examples should not be a critical problem.
Where: * Under examples and testing * And the default value is less than 2048 Using a bit more memory for examples and tests should not be a critical problem.
|
@xiaoxiang781216 ok. done |
Should we change SYSTEM_RAMTEST_STACKSIZE too? |
…KSIZE Given what this program does, it's probably ok to allocate a few more kilo bytes of the stack.
|
i guess stack size is not too important for what ramtest does. done. |
2 participants
No description provided.