-
Notifications
You must be signed in to change notification settings - Fork 682
wamr: add a few missing options to match the wamr repo counterpart #2448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
i have no idea about the CI failure. |
Just rebase to fix the issue! @simbit18 modified the config script. |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds two new configuration parameters. CI build seems unrelated.
|
is related to this Configuration/Tool: stm32f334-disco/nsh,CONFIG_ARM_TOOLCHAIN_CLANG https://github.com/apache/nuttx-apps/actions/runs/9990672271/job/27611925490?pr=2448#step:7:814 UPDATE My PR apache/nuttx#12721 basically enables/disables with -N the build with Cmake-Ninja. Currently this PR #2446 has not been merged so everything is built with make These configurations of the stm32f334-disk board https://github.com/apache/nuttx/blob/master/tools/ci/testlist/arm-10.dat So if my PR #2446 is merged surely the job Linux (arm-10) does not generate error. However, it remains to be understood what generates error this configuration stm32f334-disco:nsh built with make. |
Please see simbit18 message for more details :-) |
|
let's merge this minor change to avoid wasting ci resource. |
Summary
wamr: add a few missing options to match the wamr repo counterpart
Impact
Testing