-
Notifications
You must be signed in to change notification settings - Fork 682
module build:replace BUILD_LOADABLE with MODULES #2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patacongo please advise on nomenclature change :-)
I am not so much involved these days but in the past, configuration names began with CONFIG_ (of course) then what was being modified ( for example, NET for anyting affecting the network, and then the remainder describing what is being configured. So by those old rules, CONFIG_MODULES would be wrong. Since it affects the build system, it should be CONFIG_BUILD_MODULES. What is configured? BUILD system But since no one has been monitoring this I am sure that that naming system has gone to hell. This is not documented to my knowledge, but there are other documented naming conventions here: https://cwiki.apache.org/confluence/display/NUTTX/Wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets finish the nomenclature change discussion resolution first on the nuttx PR: apache/nuttx#13452.
|
@xuxin930 @xiaoxiang781216 |
Hi @masayuki2009 , sorry for the compatibility issue. I'll try to modify it to add instead of replace to ensure compatibility |
hi @masayuki2009 i add both MODULE config and modules option in this patch apache/nuttx#13532. |
Summary
this patch is relate to: apache/nuttx#13452
Impact
Testing