Skip to content

Conversation

@xuxin930
Copy link
Contributor

Summary

this patch is relate to: apache/nuttx#13452

Impact

Testing

Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patacongo please advise on nomenclature change :-)

@patacongo
Copy link
Contributor

patacongo commented Sep 15, 2024

@patacongo please advise on nomenclature change :-)

I am not so much involved these days but in the past, configuration names began with CONFIG_ (of course) then what was being modified ( for example, NET for anyting affecting the network, and then the remainder describing what is being configured.

So by those old rules, CONFIG_MODULES would be wrong. Since it affects the build system, it should be CONFIG_BUILD_MODULES.

What is configured? BUILD system
What is controlled in the build system? MODULE support.

But since no one has been monitoring this I am sure that that naming system has gone to hell.

This is not documented to my knowledge, but there are other documented naming conventions here: https://cwiki.apache.org/confluence/display/NUTTX/Wiki

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets finish the nomenclature change discussion resolution first on the nuttx PR: apache/nuttx#13452.

@xiaoxiang781216 xiaoxiang781216 merged commit d3942fa into apache:master Sep 19, 2024
@masayuki2009
Copy link
Contributor

@xuxin930 @xiaoxiang781216
I noticed that the PR does not work with kconfig-frontends but works with kconfiglib.
Do you mean that kconfig-frontends is no longer supported?

@xuxin930
Copy link
Contributor Author

@xuxin930 @xiaoxiang781216 I noticed that the PR does not work with kconfig-frontends but works with kconfiglib. Do you mean that kconfig-frontends is no longer supported?

Hi @masayuki2009 , sorry for the compatibility issue. I'll try to modify it to add instead of replace to ensure compatibility

@xuxin930
Copy link
Contributor Author

@xuxin930 @xiaoxiang781216 I noticed that the PR does not work with kconfig-frontends but works with kconfiglib. Do you mean that kconfig-frontends is no longer supported?

hi @masayuki2009 i add both MODULE config and modules option in this patch apache/nuttx#13532.
which both work in two Kconfig implementation library.

@lupyuen lupyuen mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants