Skip to content

Conversation

@XuNeo
Copy link
Contributor

@XuNeo XuNeo commented Sep 29, 2024

Summary

Add smp_call from interrupt test.

Impact

Testing

Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
@nuttxpr
Copy link

nuttxpr commented Sep 29, 2024

[Experimental Bot, please feedback here]

This PR summary is too short and does not provide enough information.

Here's what's missing and how to improve it:

Summary:

  • Why is this change necessary? Is it fixing a bug? Adding a new feature? Improving performance?
  • What functional part of the code is being changed? Be specific! Mention the files, modules, or subsystems affected.
  • How does the change work? Explain the technical details of your implementation.

Impact:

  • You've left all the impact sections blank. Go through each one and answer YES or NO. If the answer is YES, you must provide a description. For example, if the change impacts the build process, explain how.

Testing:

  • You need to provide actual testing logs! The current placeholders are not helpful.
  • Be specific about your testing environment:
    • Operating system and version for your build host
    • Compiler and version
    • Target architecture and board configuration
  • Include logs that clearly demonstrate the problem before your change and the improvement after your change.

In short, you need to provide much more detail to demonstrate that you've thoroughly considered the impact of your changes and that they work as intended.

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message with explanation for this change

@XuNeo XuNeo marked this pull request as ready for review September 30, 2024 08:52
@xiaoxiang781216
Copy link
Contributor

please add a commit message with explanation for this change

@jerpelea the commit message already explains clearly. Could you review the patch content before asking to add the new message?

@xiaoxiang781216 xiaoxiang781216 merged commit 9cc9a83 into apache:master Oct 1, 2024
@XuNeo XuNeo deleted the ostest-smp-call-from-interrupt branch October 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants