Skip to content

Conversation

@Gary-Hobson
Copy link
Contributor

Summary

fix noteprint compile error
The sched_note_string/bprintf/dump interfaces have been removed and replaced with printf and event

Impact

None

Testing

sim/note

The sched_note_string/bprintf/dump interfaces have been removed and replaced with printf and event

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 8, 2024 that may be closed by this pull request
@nuttxpr
Copy link

nuttxpr commented Oct 8, 2024

[Experimental Bot, please feedback here]

This PR does not meet the NuttX requirements.

Here's why and how to improve it:

  • Summary:

    • Missing details: You haven't explained why the original interfaces were removed and replaced. What problem did this solve? Be specific about the compile error.
    • Functional part: Be more specific than just "sched". Which files/functions were changed?
  • Impact:

    • Potentially inaccurate: Even seemingly small changes can have unexpected impacts. While "None" might be true for most categories, you need to think critically about each one. For example:
      • Compatibility: Did removing the old interfaces break any existing code?
      • Documentation: Does anything need to be updated to reflect these changes?
  • Testing:

    • Insufficient information:
      • Build host: Specify your development environment (OS, compiler version, etc.).
      • Target: "sim/note" is not specific enough. Which simulator? Which configuration of the note example?
    • Missing logs: You need to provide actual logs from before and after the change to demonstrate the problem and the fix.

To improve this PR:

  1. Expand the summary: Explain the reasoning behind the change and the specific compile error.
  2. Review the impact: Carefully consider each category. Don't just assume "None".
  3. Provide detailed testing information: Include your build host details, the exact target configuration, and relevant logs showcasing the issue and the fix.

@xiaoxiang781216
Copy link
Contributor

@Gary-Hobson let's enable it in some defconfig.

@xiaoxiang781216 xiaoxiang781216 merged commit 30df081 into apache:master Oct 8, 2024
@XuNeo
Copy link
Contributor

XuNeo commented Oct 11, 2024

@Gary-Hobson let's enable it in some defconfig.

Added in apache/nuttx#14093
Fixed warnings in #2681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EXAMPLES_NOTEPRINTF and SYSTEM_NOTE don't build

4 participants