Skip to content

Conversation

@jerpelea
Copy link
Contributor

Reverts #2670
revert until LVGL is released

@nuttxpr
Copy link

nuttxpr commented Oct 10, 2024

[Experimental Bot, please feedback here]

Meets Requirements?

No.

Missing Information:

  • Summary: While it mentions reverting a specific PR, it lacks details on why this is necessary. Is the LVGL update causing issues? What problems does this revert solve?
  • Impact: This section is completely empty. The PR needs to outline the impact on users, builds, hardware, documentation, etc. Reverting changes can have significant consequences that need to be explained.
  • Testing: No testing logs are provided. Even though this is a revert, you must demonstrate that the revert achieves the desired outcome (e.g., fixes a bug, restores previous functionality).

Recommendation:

Expand the PR description to address the missing information. Provide clear explanations and relevant testing logs to ensure the PR is thorough and meets NuttX's requirements.

@jerpelea
Copy link
Contributor Author

@lupyuen please merge the PR

@xiaoxiang781216 xiaoxiang781216 merged commit 42f2b44 into releases/12.7 Oct 10, 2024
@jerpelea jerpelea deleted the revert-2670-bp-2592 branch October 10, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants