nshlib: Fix stack-buffer-overflow of nsh_redirect() #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Board/Config/Command sim:nsh cat < /etc/init.d/rc.sysinit Problem The NSH hangs after exec the test command. `nsh_redirect()` needs to save three fd but array length is only two, stack buffer overflowed! Related: apache#2469 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
JianyuWang0623
force-pushed
the
br_wjy_nsh_redirect_stack_1012
branch
from
7ad700f to
47830e9
Compare
xiaoxiang781216
approved these changes
Oct 12, 2024
cederom
approved these changes
Oct 12, 2024
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @JianyuWang0623 :-)
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
JianyuWang0623
force-pushed
the
br_wjy_nsh_redirect_stack_1012
branch
from
47830e9 to
ca74f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The NSH hangs after exec the test command.
nsh_redirect()needs to save three fd(stderr, stdout and stdin) but array length is only two, stack buffer overflowed!Related: #2469
Impact
nsh/redirect
Testing