Skip to content

Conversation

@realprocrastinator
Copy link

Summary

This is an improved testing program for apache/nuttx#14152 which tests the behaviour of the setjmp when invoking longjmp with the second argument as 0.

Impact

Improve the testing scope for setjmp and longjmp.

Testing

N/A

Signed-off-by: Gao Jiawei <gaojiawei@xiaomi.com>
@nuttxpr
Copy link

nuttxpr commented Oct 12, 2024

[Experimental Bot, please feedback here]

No, the PR does not meet the NuttX requirements.

Missing Information:

  • Detailed description of the change: The summary only mentions an "improved testing program" but lacks specifics on the changes made.
  • Functional area: The code section being modified (e.g., libc, kernel, drivers) is not specified.
  • Impact assessment: While mentioning improved testing, the PR needs to address all impact points, especially:
    • How the change affects functionality (if at all)?
    • Will users need to adapt?
    • Are there any build system, hardware, documentation, security, or compatibility implications?
  • Testing details:
    • Host and target environments: Specify the OS, architecture, compiler, board, and configuration used for testing.
    • Testing logs: Provide concrete logs demonstrating the issue before the change and the improvement after the change.

Recommendations:

  1. Expand the Summary: Provide a clear and concise explanation of the changes made in the testing program.
  2. Specify the Functional Area: Indicate the specific part of the codebase being modified.
  3. Complete the Impact Assessment: Thoroughly analyze and address all impact points, providing specific details where applicable.
  4. Provide Detailed Testing Information: Include the host and target environments used and share relevant testing logs showing the before and after states.

@xiaoxiang781216
Copy link
Contributor

let's ignore ci check error which is fixed by #2712 to avoid wasting github resources.

@xiaoxiang781216 xiaoxiang781216 merged commit 63542f8 into apache:master Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants