Skip to content

Conversation

@Gary-Hobson
Copy link
Contributor

@Gary-Hobson Gary-Hobson commented Oct 12, 2024

Summary

osperf: changes irq_t to irqstate_t

Impact

pass build

Testing

ci

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@cederom
Copy link
Contributor

cederom commented Oct 12, 2024

Thanks @Gary-Hobson, please update PR description, we will not accept PR with blank descriptions, see https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md.

Why irq_t is changed to irqstat_t ? We can see from diff it is changed, but more important is why? Please always provide few description sentences to provide a context :-)

@xiaoxiang781216
Copy link
Contributor

let's ignore ci check error which is fixed by #2712 to avoid wasting github resources.

@xiaoxiang781216 xiaoxiang781216 changed the title osperf: changes irq_t to irqstat_t osperf: changes irq_t to irqstate_t Oct 13, 2024
@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Oct 13, 2024

Thanks @Gary-Hobson, please update PR description, we will not accept PR with blank descriptions, see https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md.

Why irq_t is changed to irqstat_t ? We can see from diff it is changed, but more important is why? Please always provide few description sentences to provide a context :-)

irq_t represents the interrupt number: https://github.com/apache/nuttx/blob/master/include/nuttx/irq.h#L56-L64
irq_state_t represents is the irq mask: https://github.com/apache/nuttx/blob/master/arch/arm/include/types.h#L107-L120

@xiaoxiang781216 xiaoxiang781216 merged commit 524eb08 into apache:master Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants