quickjs: fix mp_mul multiple definition #2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in function `mp_mul': apps/interpreters/quickjs/quickjs/libbf.c:1179: multiple definition of `mp_mul'; nuttx/staging/libapps.a:apps/math/libtommath/libtommath/bn_mp_mul.c:8: first defined here Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
cederom
approved these changes
Oct 12, 2024
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @Gary-Hobson :-)
Contributor
|
let's ignore ci check error which is fixed by #2712 to avoid wasting github resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in function
mp_mul': apps/interpreters/quickjs/quickjs/libbf.c:1179: multiple definition ofmp_mul'; nuttx/staging/libapps.a:apps/math/libtommath/libtommath/bn_mp_mul.c:8: first defined hereImpact
Testing
sim