-
Notifications
You must be signed in to change notification settings - Fork 682
smpcall: add nxsched_smp_call_async and nxsched_smp_call_single_async #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reason: The old implementation of the SMP call, even when using the "no wait" parameter, could still result in waiting, if invoking it within a critical section may lead to deadlocks. Therefore, in order to implement a truly asynchronous SMP call strategy, we have added nxsched_smp_call_async. Signed-off-by: hujun5 <hujun5@xiaomi.com>
|
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. Here's why:
In short, the PR description needs to be significantly more detailed and address all the points listed in the NuttX requirements template. It currently provides only a very high-level overview and lacks essential information for proper review. |
cederom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hujun260 :-) Some build errors please fix :-)
|
These two pull requests (PRs) must be merged together. |
|
Looks like this broke some other things as seen in CI builds following the merge? https://github.com/apache/nuttx-apps/actions/runs/11699250290/job/32580956611?pr=2826 I have restarted the failed CI job just to make sure :-) |
|
already fixed by: apache/nuttx#14664 and #2822 |
Summary
reason:
The old implementation of the SMP call, even when using the "no wait" parameter, could still result in waiting, if invoking it within a critical section may lead to deadlocks. Therefore, in order to implement a truly asynchronous SMP call strategy, we have added nxsched_smp_call_async.
#2822
apache/nuttx#14656
These two pull requests (PRs) must be merged together.
Impact
smp call
Testing
ci ostest
Build Host:
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx