nxaudio: fix audio stop logic to prevent buffer addition after STOP signal #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignal - Ensure `AUDIO_STOP` via `ioctrl` is followed by `mq_send STOP` without race conditions. - Modify loop condition to correctly handle `running = false` upon receiving STOP signal. - Resolve potential issue where `AUDIO_MSG_DEQUEUE` could still accept buffers after STOP signal due to timing. Before: - `nxaudio_stop` would call `ioctrl AUDIO_STOP` followed by `mq_send STOP`, which might lead to `AUDIO_MSG_DEQUEUE` accepting buffers after STOP. After: - Synchronized the sequence of `ioctrl AUDIO_STOP` and `mq_send STOP` to prevent buffer addition after STOP. - Enhanced loop condition to accurately reflect the STOP state. Signed-off-by: xinbingnan <xinbingnan@xiaomi.com>
Member
|
Sorry I have to cancel the CI Check, there's a problem with CI Test: |
Contributor
Author
That's OK, let's wait for the issue to be resolved |
xiaoxiang781216
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AUDIO_STOPviaioctrlis followed bymq_send STOPwithout race conditions.running = falseupon receiving STOP signal.AUDIO_MSG_DEQUEUEcould still accept buffers after STOP signal due to timing.Before:
nxaudio_stopwould callioctrl AUDIO_STOPfollowed bymq_send STOP, which might lead toAUDIO_MSG_DEQUEUEaccepting buffers after STOP.After:
ioctrl AUDIO_STOPandmq_send STOPto prevent buffer addition after STOP.Impact
N/A
Testing
N/A