Skip to content

nshlib/cmd_dd: Retry if read() was interrupted #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 1 commit into from
Nov 11, 2024
Merged

nshlib/cmd_dd: Retry if read() was interrupted #2837

xiaoxiang781216 merged 1 commit into from
Nov 11, 2024

Conversation

@JianyuWang0623
Copy link
Contributor

@JianyuWang0623 JianyuWang0623 commented Nov 10, 2024 •
edited
Loading

Summary

nshlib/cmd_dd: Retry if read() was interrupted

  • Without this patch
nsh> ls /etc/group | dd | dd
sh [13:100]
sh [14:100]
nsh: dd: read failed: 4
nsh>
  • With this patch
nsh> ls | dd | dd | dd | dd | dd
sh [4:100]
sh [5:100]
sh [6:100]
sh [7:100]
sh [8:100]
/:
 bin/
 dev/
 etc/
 proc/
 tmp/
 var/
nsh>

Link: #2833 (same reason), #2737 (nsh pipeline)

Impact

nshlib/cmd_dd

Testing

  • nsh:sim with pipeline enabled
  • NuttX CI

@JianyuWang0623
nshlib/cmd_dd: Retry if read() was interrupted
c125dc4 
Without this patch

  nsh> ls /etc/group | dd | dd
  sh [13:100]
  sh [14:100]
  nsh: dd: read failed: 4
  nsh>

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 27b5021 into apache:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

Area: NSH Size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JianyuWang0623 @xiaoxiang781216