testing: fix compilation issues with missing header files #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
Area: System
Area: Testing
Area: Examples
Size: S
labels
Contributor
|
@txy-21 please fix: |
Add malloc.h header file to fstest.h to fix missing malloc/free function declarations in filesystem test suites. Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add missing header files in netutils and lsan modules to fix implicit function declarations and improve compilation compatibility. Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add unistd.h and pthread.h for memorystress_main.c, unistd.h for dhm.c and cachetest_main.c, and pthread.h for kv_test_019.c to fix missing declarations. Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
Add unistd.h header file to drivertest_touchpanel.c to fix missing sleep/usleep function declarations in touchpanel driver tests. Signed-off-by: tengshuangshuang <tengshuangshuang@xiaomi.com>
txy-21
force-pushed
the
testing-header-fixes
branch
2 times, most recently
from
8ed1cc3 to
179bcc6
Compare
Fix cast from pointer to integer of different size to ensure proper type conversion and avoid compilation warnings. Signed-off-by: hongfengchen <hongfengchen@xiaomi.com>
txy-21
force-pushed
the
testing-header-fixes
branch
from
179bcc6 to
12bba70
Compare
Contributor
Author
@xiaoxiang781216 Done |
| {"REIN", ftpd_command_rein, FTPD_CMDFLAG_LOGIN}, /* REIN <CRLF> */ | ||
| {"STOU", ftpd_command_stou, FTPD_CMDFLAG_LOGIN}, /* STOU <CRLF> */ | ||
| {"STAT", ftpd_command_stat, FTPD_CMDFLAG_LOGIN}, /* STAT [<SP> <pathname>] <CRLF> */ | ||
| {"ALLO", ftpd_command_stat, FTPD_CMDFLAG_LOGIN}, /* ALLO <SP> <decimal-integer> [<SP> R <SP> <decimal-integer>] <CRLF> */ |
Contributor
There was a problem hiding this comment.
this line can't change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple compilation issues in testing and netutils modules by adding missing POSIX header files. These changes ensure proper compilation across different platforms and build configurations.
Changes
This PR includes 5 commits addressing header file dependencies:
Files Modified
testing/testsuites/kernel/fs/include/fstest.h- Added malloc.hnetutils/codecs/md5.c- Added missing headernetutils/ftpd/ftpd.c- Added missing headersystem/lsan/lsan_main.c- Added missing headertesting/mm/memstress/memorystress_main.c- Added unistd.h and pthread.htesting/drivers/crypto/dhm.c- Added unistd.htesting/mm/cachetest/cachetest_main.c- Added unistd.htesting/drivers/drivertest/drivertest_touchpanel.c- Added unistd.hnetutils/rexecd/rexecd.c- Fixed type cast issueImpact
Testing
Test Environment
Test Steps
Test Results