Set CONFIG_NET_ETH_PKTSIZE to 1514 for spresense #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
https://en.wikipedia.org/wiki/Ethernet_frame#Ethernet_II The original Ethernet IEEE 802.3 standard defined the minimum Ethernet frame size as 64 bytes and the maximum as 1518 bytes (1500+header/trailer). The maximum was later increased to 1522 bytes to allow for VLAN tagging. |
WaterBirdWayOrigin
force-pushed
the
fixedethernetpacketsizeforspresense
branch
from
cebd86e to
2b4c89c
Compare
Set CONFIG_NET_ETH_PKTSIZE to 1514 when performing $ tools/configure.sh spresense/rndis configuration CONFIG_NET_ETH_PKTSIZE defines the size of ethernet packet. Ethernet packet size is 1514 including the ethernet header. This commit can send 1514 bytes packet as follow: e.g) For OpenWrt Router nsh> ping -c 1 -s 1472 192.168.1.1 PING 192.168.1.1 1472 bytes of data 1472 bytes from 192.168.1.1: icmp_seq=0 time=0 ms 1 packets transmitted, 1 received, 0% packet loss, time 1010 ms nsh> https://tools.ietf.org/html/rfc894 said at Frame Format ``` The minimum length of the data field of a packet sent over an Ethernet is 1500 octets, thus the maximum length of an IP datagram sent over an Ethernet is 1500 octets. Implementations are encouraged to support full-length packets. `` Just for your information, include/nuttx/net/ethernet.h:78:#define ETH_HDRLEN 14 /* Header size: 2*6 + 2 */ Signed-off-by: Koichi Okamoto <Koichi.Okamoto@sony.com>
Contributor
Author
|
Thank you for your comment. I am sorry I used wrong e-mail address for signoff. So, I close this PR once and recreate another one agin and reply to your comment. |
Contributor
|
there is no problem |
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 6, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 10, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 11, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
extinguish
pushed a commit
to extinguish/nuttx
that referenced
this pull request
Aug 12, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
anchao
pushed a commit
that referenced
this pull request
Aug 19, 2024
"stdio/lib_dtoa_engine.c", line 102: error #166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning #1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error #109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error #166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning #1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error #109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error #166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning #1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error #109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error #166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning #1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error #109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error #166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning #1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error #109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
medexs
pushed a commit
to medexs/nuttx
that referenced
this pull request
Sep 19, 2024
"stdio/lib_dtoa_engine.c", line 102: error apache#166: invalid floating constant if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 102: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x < MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#166: invalid floating constant if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 107: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y < MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#166: invalid floating constant if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 119: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (y >= MIN_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#166: invalid floating constant if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 144: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type if (x >= MAX_MANT) ^ "stdio/lib_dtoa_engine.c", line 153: error apache#166: invalid floating constant uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: warning apache#1626-D: concatenation with "(" in macro "PASTE" does not create a valid token uint64_t decimal = MIN_MANT_INT; ^ "stdio/lib_dtoa_engine.c", line 153: error apache#109: expression preceding parentheses of apparent call must have (pointer-to-) function type uint64_t decimal = MIN_MANT_INT; Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CONFIG_NET_ETH_PKTSIZE to 1514 when performing
$ tools/configure.sh spresense/rndis
configuration
CONFIG_NET_ETH_PKTSIZE defines the size of ethernet packet.
Ethernet packet size is 1514 including the ethernet header.
This commit can send 1514 bytes packet as follow:
e.g) For OpenWrt Router
nsh> ping -c 1 -s 1472 192.168.1.1
PING 192.168.1.1 1472 bytes of data
1472 bytes from 192.168.1.1: icmp_seq=0 time=0 ms
1 packets transmitted, 1 received, 0% packet loss, time 1010 ms
nsh>
https://tools.ietf.org/html/rfc894
said at Frame Format